anidl / multi-downloader-nx

Downloader for Crunchyroll, Hidive, AnimeOnegai, and AnimationDigitalNetwork with CLI and GUI
MIT License
265 stars 44 forks source link

[BUG] #55

Closed Mytic-Slander closed 3 years ago

Mytic-Slander commented 3 years ago

does anyone know why? Screenshot_17

izu-co commented 3 years ago

You can only use Funimation from specific countries (e.g. USA or Canada).

Depending on where you live, your access to Funimation may be restricted.

darkhelmet2016 commented 3 years ago

They now also cover other regions like UK and Ireland. But it looks like the program will need an overhaul as the entire site layout has changed.

izu-co commented 3 years ago

But it looks like the program will need an overhaul as the entire site layout has changed.

Well you can still download older episodes. The problem for new ones is that they changed how the files are served.

darkhelmet2016 commented 3 years ago

Eventually those will be changed too. Not all of the site updates have taken effect yet as they will have to be updated for uniformity and those will no longer be downloadable either.

izu-co commented 3 years ago

I thought so. If I had more time I would try to fix the downloader, but I can't find the time lately.

darkhelmet2016 commented 3 years ago

Reading another thread they have changed embedded video player to Brightcove.

alzeric commented 3 years ago

I'll have a working version later tonight most likely

Already got most the new API worked out image

izu-co commented 3 years ago

I'll have a working version later tonight most likely

Seams nice. If you need help, feel free to ask me.

alzeric commented 3 years ago

[Update] Haven't forgotten, I'm doing a full rewrite fixing a few things that bothered me along the way. Will be a bit longer.

Adding full interactive mode as well as straight CLI, should make using it a lot easier and streamlined. Also will have AES-256 encryption for your token as well instead of it laying in plain text Fully updated Funimation API

Adding a couple other little bells and whistles as well, which is why it's taking longer than I intended.

anidl-git commented 3 years ago

try this https://github.com/anidl/funimation-downloader-nx/releases/tag/4.8.0-beta.1 @alzeric please send your discord id to my mail: anidlteam@gmail.com

izu-co commented 3 years ago

It seems like it is downloading the whole video every part.

hls-download can't handle the newly added 'byterange'.

cimmy01 commented 3 years ago

Just tried the new version on cells at work season 2 eng dub and Ill im getting is this error stream. [WARN] Part 3: 5 attempt to retrieve data ERROR: Timeout awaiting 'request' for 60000ms [WARN] Part 9: 5 attempt to retrieve data ERROR: Timeout awaiting 'request' for 60000ms [ERROR] Part 1 download error: Timeout awaiting 'request' for 60000ms [ERROR] Part 10 download error: Timeout awaiting 'request' for 60000ms [ERROR] Part 8 download error: Timeout awaiting 'request' for 60000ms [ERROR] Part 7 download error: Timeout awaiting 'request' for 60000ms [ERROR] Part 6 download error: Timeout awaiting 'request' for 60000ms [ERROR] Part 4 download error: Timeout awaiting 'request' for 60000ms [ERROR] Part 2 download error: Timeout awaiting 'request' for 60000ms [ERROR] 7 parts not downloaded [ERROR] DL Stats: {"first":0,"total":716,"completed":0}

(node:9664) UnhandledPromiseRejectionWarning: ReferenceError: reqVideo is not defined at downloadStreams (U:\GitHub\funimation-downloader-nx-master\funi.js:583:9) at processTicksAndRejections (internal/process/task_queues.js:97:5) at async getEpisode (U:\GitHub\funimation-downloader-nx-master\funi.js:374:13) at async getShow (U:\GitHub\funimation-downloader-nx-master\funi.js:251:13) (node:9664) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:9664) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

izu-co commented 3 years ago

@cimmy01 Please try my pull request. It addresses this issue.

The audio and video is currently not joined, but you could do that yourself.

cimmy01 commented 3 years ago

I tried and it just broke it worse. It will still only throw the error on the "new episodes"

izu-co commented 3 years ago

Do you have the error?

cimmy01 commented 3 years ago

I don't I started over and im still working on it

cimmy01 commented 3 years ago

Here is the error Im getting U:\GitHub\funimation-downloader-nx-master\modules\module.getdata.js:47 i if(res.body && (options.responseType !== 'buffer' && res.body.match(/^</))){ ^^

SyntaxError: Unexpected token 'if' at wrapSafe (internal/modules/cjs/loader.js:1071:16) at Module._compile (internal/modules/cjs/loader.js:1121:27) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1177:10) at Module.load (internal/modules/cjs/loader.js:1001:32) at Function.Module._load (internal/modules/cjs/loader.js:900:14) at Module.require (internal/modules/cjs/loader.js:1043:19) at require (internal/modules/cjs/helpers.js:77:18) at Object. (U:\GitHub\funimation-downloader-nx-master\funi.js:27:17) at Module._compile (internal/modules/cjs/loader.js:1157:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1177:10) U:\GitHub\funimation-downloader-nx-master>

izu-co commented 3 years ago

Well the 'i' in front of the if is not from me

cimmy01 commented 3 years ago

I retraced my steps and got it to download the video However it still threw an exception for the audio. Did I miss a step? text of the transaction [INFO] Cells at Work! - S2E01 - Bump [INFO] Available streams (Non-Encrypted): [#1320196] Japanese [Simulcast] [#1456585] English [Simulcast] (selected) [INFO] Servers available: vmfst-api.prd.funimationsvc.com [INFO] Available qualities: 1: 234p (332KiB/s) 2: 360p (579KiB/s) 3: 432p (966KiB/s) 4: 432p (1354KiB/s) 5: 540p (2480KiB/s) 6: 720p (3584KiB/s) 7: 720p (5345KiB/s) 8: 1080p (7059KiB/s) 9: 1080p (9194KiB/s) [INFO] Selected layer: 9 (1080p) @ vmfst-api.prd.funimationsvc.com [INFO] Stream URL: https://vmfst-api.prd.funimationsvc.com/FunimationStoreFront/V2140836/d0e1cd01-50d8-4775-83fa-a7e59fd0deebstrnv-hl154_streaming_video_1920_1080_7800000_index.m3u8?Key-Pair-Id=APKAIHNXECY27H4O6NIA&Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cHM6Ly9kMzNldDc3ZXZkOWJnZy5jbG91ZGZyb250Lm5ldC9GdW5pbWF0aW9uU3RvcmVGcm9udC9WMjE0MDgzNi8qIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNjE5OTg3OTI0fX19XX0_&Signature=rQxCD84iwQ7mf8~lE3VWc23y8oTJiqiMZlKGmN9KFqdCGmO9MqXzPzwhxA-AIY4VO4GLplp7Js-LpaySvwzOD1gBCkfJTS3RdR5hvhmPbMbi4NKbBqNOZZnCDIjOcVWcp9K0fX8FXVJxF2wD6JNXXLt0D7mjRiHn~ahTPkoQwpVquwGpSBdhRQ8Ox08tsl~JG0ppkwOQ7bQOeABQ3dtBd~Cx6QJyLlMoDmKrAz2f459dJ-tOr5~f4STrR6jSCy1zrW1FXv8QgfAk-iUhiF4nXSrXIwQA5GispKI~WpEufPSkY~z3Fi8ynSCmhA4bZ-iLm2pP5agjjPpm6mkKnEOrUw__&rt=1420044 [INFO] Output filename: [Funimation] Cells at Work! - 01 [1080p].ts [INFO] Downloaded 19% (199637kb/1042361kb) [INFO] Downloaded 42% (434600kb/1042361kb) [INFO] Downloaded 67% (695937kb/1042361kb) [INFO] Downloaded 86% (892282kb/1042361kb) [INFO] Finished d:\downloaded\videos[Funimation] Cells at Work! - 01 [1080p] (node:11552) UnhandledPromiseRejectionWarning: ReferenceError: reqVideo is not defined at downloadStreams (U:\GitHub\funimation-downloader-nx-master\funi.js:641:9) at processTicksAndRejections (internal/process/task_queues.js:97:5) at async getEpisode (U:\GitHub\funimation-downloader-nx-master\funi.js:376:13) at async getShow (U:\GitHub\funimation-downloader-nx-master\funi.js:253:13) (node:11552) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:11552) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

izu-co commented 3 years ago

Well it seems like you missed my first pull request. I fixed some typos like reqVideo being reqAudio.

Here is the funi.js file as it should be. https://pastebin.com/Rturj8dX

cimmy01 commented 3 years ago

Awesome Thank you that has me going again I thought I got all of the revisions in but I guess I did miss a couple

KaIZeR99-code commented 3 years ago

Can't use VPN to download from Funimation? Cause I can access Funimation using VPN from outside US... It should also worked then...

alzeric commented 3 years ago

Can't use VPN to download from Funimation? Cause I can access Funimation using VPN from outside US... It should also worked then...

Yes VPN will work

NatsuFT36 commented 3 years ago

But it does not support regions like Mexico and Brazil since those territories expanded and that is what I live in Mexico

izu-co commented 3 years ago

The program is not responsible for the regions. It is up to funimation to determine whether you are allowed to enter their site from your location.

NatsuFT36 commented 3 years ago

But in funimation it supports in Mexico and there I was seeing the Megalobox Nomad series dubbed but it cannot be downloaded and it throws error 403

izu-co commented 3 years ago

Well I can’t tell you why this is, but if the website works so should the program. But, like I said, we can’t work around it. 403 means that funimation does not accept your request.

NatsuFT36 commented 3 years ago

Besides they do not download chapters like Blue Reflection Ray chapter 6 and that uses a US VPN and nothing

izu-co commented 3 years ago

I would assume that this issue has been resolved. If not, reopen it or create a new one, please.