search

animo / aries-mobile-sdk

Apache License 2.0
8 stars 2 forks source link

Design abstraction layer for supporting multiple attachments formats #22

Closed TimoGlastra closed 2 years ago

TimoGlastra commented 3 years ago

Issue Credential and Present Proof v1 only supported a single credential type. The v2 protocols now support an attachment registry that supports multiple exchange formats. We need to design an abstraction layer where we could use multiple attachments formats in the same protocol implementation. Ideally a new attachment format should only consist of adding a new attachment format implementation, not modifying the protocol implementation.

Todo

karimStekelenburg commented 3 years ago

Not sure, because I'm not good at reading Go code, but it looks like AFGO use a Format key to indicate which format is used: https://github.com/hyperledger/aries-framework-go/blob/2d601d717a3e2297662faf622f7a878e0f50f981/pkg/client/issuecredential/rfc0593/event.go#L203.

TimoGlastra commented 3 years ago

From our discussion last Thursday:

Untitled-2021-10-05-1552