anish2690 / vue-draggable-next

Vue 3 drag-and-drop component
https://vue-draggable-next.vercel.app
MIT License
505 stars 44 forks source link

sortablejs peerDependency is bundled in dist output #24

Open wopian opened 2 years ago

wopian commented 2 years ago

sortablejs is bundled in all but the TypeScript type definition files in /dist (https://www.jsdelivr.com/package/npm/vue-draggable-next?path=dist)

This leaves us with a missing peer dependency warning if we do not add it (which is annoying, but fine as we don't use TypeScript) or 7 copies of sortablejs if we install the peer dependency (the package and 6 copies of whichever version is bundled in a vue-draggable-next release)

It also has the side effect of the type definitions not being in sync with the version of sortablejs being used by vue-draggable-next for TypeScript users.

Can sortablejs be added as a dependency (preferred) or unbundle the peerDependency so the install instructions become (yarn add vue-draggable-next sortablejs)?

dmix commented 2 years ago
Screenshot 2022-06-27 at 5 59 21 PM

this is the warning for the latest version

anish2690 commented 2 years ago

@wopian working on it.