Animation should me shown when back button is pressed in the game map screen.

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.

GNU General Public License v2.0

116 stars 430 forks source link

Animation should me shown when back button is pressed in the game map screen. #1348

Closed moksh-mahajan closed 4 years ago

moksh-mahajan commented 5 years ago

Description

In the game map screen, when a building is clicked, then a nice animation effect is shown when the screen changes from map to conversation scenario. Also when the user goes back to map screen from any conversation screen using the home button (on the top right corner), then also the animation effect is shown. But when the back button is pressed, this animation effect is not shown. My idea is to add this animation effect when the back button is pressed too.

Mocks

20190224_172301

Update [Required]

[x] Add the animation effect when back button is pressed.

Definition of Done

[x] All of the required items are completed.
[ ] Approval by 1 mentor.

moksh-mahajan commented 5 years ago

I would like to work on this issue. @Rimjhim28 @geekanamika

Rimjhim28 commented 5 years ago

This looks valid. @moksh-mahajan You can send a PR for this.

moksh-mahajan commented 5 years ago

@Rimjhim28 sending a PR soon.

moksh-mahajan commented 5 years ago

@Rimjhim28 Done. Please review.

Priyansh-Kedia commented 4 years ago

@Rimjhim28 May I work on this issue?

Priyansh-Kedia commented 4 years ago

@sunjunkie May I work on this issue?

Priyansh-Kedia commented 4 years ago

@sidvenu May I work on this?

sidvenu commented 4 years ago

Hey Priyansh! I'm not a maintainer for this project.

Priyansh-Kedia commented 4 years ago

@sidvenu Could you please tell me the maintainers for the same? Thanks.