anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
116 stars 430 forks source link

App crashes on backpressed from MemoryMatchGameActivity #1370

Closed Priyansh-Kedia closed 4 years ago

Priyansh-Kedia commented 4 years ago

Description

When back is pressed on MemoryMatchGame after the hospital, the app crashes.

Mocks

WhatsApp Video 2020-03-04 at 7 17 48 PM

Update [Required]

The app should not crash on back pressed, but should go to the previous activity.

Priyansh-Kedia commented 4 years ago

@mayburgos May I work on this issue?

sammy1997 commented 4 years ago

@Priyansh-Kedia Can you share the crash log? Use this https://justpaste.it/ to paste the log! I have to check if this is something device-specific or a generic error?

Priyansh-Kedia commented 4 years ago

5kzg2-justpasteit.pdf

@sammy1997 Here is the crash report.

sammy1997 commented 4 years ago

Ok. Seems like some kind of out of bound exception in MemoryMatchGameActivity. Seems like a valid issue! @Rimjhim28 @geekanamika ?

sunjunkie commented 4 years ago

I don't see a back button. Is that part of the Android OS? At any rate, why is there a back button on the Memory match game? Is is supposed to be a "replay" of the game?

Priyansh-Kedia commented 4 years ago

There is no back button as such. It is when you push back from the phone swipe up.

sunjunkie commented 4 years ago

OK. The game shouldn't crash no matter what so this seems like a valid issue.

Priyansh-Kedia commented 4 years ago

May I send a PR then?

sunjunkie commented 4 years ago

Yes, go ahead. (However, I can't review it. Someone else will have to.)

Priyansh-Kedia commented 4 years ago

Thanks. Will send a PR soon.

Priyansh-Kedia commented 4 years ago

This is the PR for the issue https://github.com/anitab-org/powerup-android/pull/1371#issue-383756297

Please review. Thanks.