ankane / ruby-polars

Blazingly fast DataFrames for Ruby
Other
860 stars 34 forks source link

Support truncate_ragged_lines option for reading CSV files #53

Closed jvdp closed 8 months ago

jvdp commented 8 months ago

Hi,

Thanks for the library! I'm getting good use out of it.

Polars can give an error message like:

found more fields than defined in 'Schema' (RuntimeError)

Consider setting 'truncate_ragged_lines=true'.

This PR adds support for it in the bindings.

ankane commented 8 months ago

Hi @jvdp, thanks for the PR. Happy to include, but please keep the arguments and code in the same order as py-polars for maintainability.

ankane commented 8 months ago

Thanks for updating. However, a lot of the code is still out-of-order (Rust code, Ruby code, @param docs).

jvdp commented 8 months ago

Fixed now! Some notes:

ankane commented 8 months ago

Looks great, thanks! Will sync the existing code in a follow-up commit.