update for new version of jellyfin 10.9.0

gaming09 commented 4 months ago

https://jellyfin.org/posts/jellyfin-release-10.9.0/ currently plugin shows as not supported

TheFrenchGhosty commented 4 months ago

Can confirm @ankenyr

Same stuff to update as when 10.7.0 updated I'm guessing?

Da-Geek commented 4 months ago

Can confirm @ankenyr

Same stuff to update as when 10.7.0 updated I'm guessing?

If you have some idea of what these changes might have been, Could we/you/I put together a PR and get this fixed? If it is as simple as just bumping a target compatibility/release number, that shouldn't cause that much hassle?

Da-Geek commented 4 months ago

Same stuff to update as when 10.7.0 updated I'm guessing?

Like are we just talking about bumping the Jellyfin Version in Jellyfin.Plugin.YoutubeMetadata/Jellyfin.Plugin.YoutubeMetadata.csproj

the line <PackageReference Include="Jellyfin.Data" Version="10.8.0" /> It surely isn't going to be that simple??

Da-Geek commented 4 months ago

Jellyfin.Plugin.YoutubeMetadata/Jellyfin.Plugin.YoutubeMetadata.csproj and Jellyfin.Plugin.YoutubeMetadata.Providers.Tests/Jellyfin.Plugin.YoutubeMetadata.Tests.csproj are the only 2 files that seem to reference Jellyfin v10.8.0 and what looks like an older file build.yaml that seems a little out of date

Does anyone have Visual Studio installed to do a quick build of the Plugin with the version string bumped, just to see if it would work? the we can chuck together a PR

Herikc2 commented 4 months ago

I tried to build a new version but I received the following error:

error NU1202: Package Jellyfin.Data 10.9.0 is not compatible with net6.0 (.NETCoreApp,Version=v6.0). Package Jellyfin.Data 10.9.0 supports: net8.0 (.NETCoreApp,Version=v8.0)

But my .NET version is 8.0.4...

Herikc2 commented 4 months ago

Same stuff to update as when 10.7.0 updated I'm guessing?

Like are we just talking about bumping the Jellyfin Version in Jellyfin.Plugin.YoutubeMetadata/Jellyfin.Plugin.YoutubeMetadata.csproj

the line <PackageReference Include="Jellyfin.Data" Version="10.8.0" /> It surely isn't going to be that simple??

Updated, I created a clean VM just to build a new release, the build was created normally but still is not compatible.

SupertCZ commented 4 months ago

I think you have to modify the targetAbi in the build.yaml file. It seems like 10.8 was backwards compatible with 10.7., however, 10.9.0 is not.

Herikc2 commented 4 months ago

I tried and did not worked.

Jchasa commented 4 months ago

Hi, I was able to update everything and clear the errors with the sdk versions, but now I have this error and it is beyond my knowledge Severity Code Description Project File Line Suppression State Error CS0246 The type or namespace name 'IPluginServiceRegistrator' could not be found (are you missing a using directive or an assembly reference?) Jellyfin.Plugin.YoutubeMetadata C:\Users\USERNAME\Source\Repos\jellyfin-youtube-metadata-plugin\Jellyfin.Plugin.YoutubeMetadata\Plugin.cs 53 Active

TheFrenchGhosty commented 4 months ago

@Jchasa This might be helpful: https://github.com/jellyfin/jellyfin-plugin-dlna/commit/09a18668e48d12e9d1fe71aa52deca12ecc40a2a

(and basically all this since the last 6 months https://github.com/jellyfin/jellyfin-plugin-dlna/commits/master/ )

ankenyr commented 4 months ago

I see this, sorry that I have not given this plugin much love. I am currently building a company and have two kids, as long as the plugin works for me I don't pay much attention, I didn't even notice someone actually donated a few bucks to the kofi account until months later. Big thanks to Seb for paying for a few cups of coffee.

I will see if I can poke around at this soon because it will certainly affect me when I update to the latest version for the family media server.

cdoucette commented 4 months ago

There are a couple forks I see that have recent updates and mention 10.9 and when you compare with this base, say they could be merged cleanly at least. NET is not my thing so I can't really help more than that or really dig into it to make sure it all works.

Perhaps one of them could do a pull request for their required changes?

nalsai commented 4 months ago

I just got it working fully. I can make a PR soon.

I'd also like to have #66 merged (I've personally been running my own custom build with it) and I'd like to take a look at #84.

voltagex commented 4 months ago

@nalsai can you make your PR? I just hit this issue too

nalsai commented 4 months ago

I've already made my PR and it has been merged. To use it, you need to download the latest pre-release and copy the following files to your jellyfin server into a subfolder of the plugins directory.