search

anki-geo / ultimate-geography

Geography flashcard deck for Anki
https://ankiweb.net/shared/info/2109889812
Other
819 stars 81 forks source link

Vectorize flags #577

Closed KentGrigo closed 2 years ago

KentGrigo commented 2 years ago

This PR will vectorize the following flags:

The following flags still need to be vectorized:

These flags were not vectorized because they also needed to be blurred:

and these flags because they didn't correspond to the first flag on Wikipedia, which I thought was the consensus based on https://github.com/anki-geo/ultimate-geography/issues/111:

axelboc commented 2 years ago

Awesome, thanks!! Did you run them through SVGO? Otherwise, maybe @ohare93 can run them through ImgBot in his fork 😁.

KentGrigo commented 2 years ago

I have now. 😅 Thanks for reminding me. I'm not familiar with SVGO so I didn't change any of the settings, except for Croatia's flag. The file size would have been +18,34% with the default settings. I disabled Move group attrs to elements as it changed it to -1.5%.

aplaice commented 2 years ago

Thanks!

I think that these should, ideally, have their height changed to 250 px and the width adjusted accordingly. (Otherwise, the images will appear huge when reviewing. (Modifying the SVG as opposed to specifying the height with CSS has, I think, the advantage that the images will also look consistent (and not huge) in the editor/browsing pane.)

Just editing height and width in the svg element should be sufficient.

~According to the guidelines, the viewBox attribute should also be added, but while I think it's needed, I'm not sure 100%...~ Edit: if the height and width are changed, then the viewBox also needs to be there. If there was no existing viewBox its value should be 0 0 oldWidth oldHeight. If there was an existing viewBox then I think it doesn't need to be changed.

One other very minor issue (which I realised while looking at #220) is that now, if one zooms in, the name of the Dominican Republic is visible. Hence, in the longer run, it might be also worth blurring.

KentGrigo commented 1 year ago

@aplaice, thank you for correcting the widths and heights, plus adding the viewBoxes.