search

ankosoftware / ng2-bootstrap-modal

Library to simplify the work with bootstrap modal dialogs
MIT License
54 stars 62 forks source link

Changed <template> to <ng-template> to eliminate Angular2 warning #24

Closed FaterW closed 1 year ago

carlmon commented 7 years ago

@bikalay please merge

Toso82 commented 7 years ago

@bikalay When merge this modify?

e-watson commented 7 years ago

@bikalay Excuse me, colleagues: what about Fater's changes merge?

anuruddha-thennakoon commented 7 years ago

Its better if merge this quickly

BearandYoon commented 7 years ago

I have also same warning on my project. Please merge this change.

socx commented 7 years ago

Please kindly merge this change.

mscoobby commented 7 years ago

Please merge.

bculley commented 7 years ago

Please merge

rajavijayavendan commented 7 years ago

Please merge the change as soon as possible.

LasithaPrabodha commented 7 years ago

Please do merge

alessandrov commented 7 years ago

please do merge

alessandrov commented 7 years ago

this warning causes issues while deploying to gae, please merge asap

nviospvkuadt commented 7 years ago

please...

luisgagocasas commented 7 years ago

please do merge

kevcjones-archived commented 7 years ago

Please merge buddy... ng5 is out now.. we want to upgrade

kevcjones-archived commented 7 years ago

I've made a fork - merged this and the this https://github.com/ankosoftware/ng2-bootstrap-modal/issues/49#issuecomment-342558956 fix to make it angular5 compatible.

Until the author returns i'll maintain this one and hopefully can fold anything back into this one. It was do this OR change package, and maybe some of you here can step sideways while we wait. Hopefully its clear enough in the readme, and of course since its a 'forked' repo that i'm not stealing or taking any credit for this authors work. I simply want an error free upgrade 👍

https://github.com/kevcjones/angularx-bootstrap-modal

[edit] Our branch is actually deviating quite a bit now and we're making some breaking changes but the premise is the same just without Bootstrap dependencies and refactoring code with tests etc.

https://github.com/kevcjones/ngx-simple-modal

celsomtrindade commented 7 years ago

@KevCJones I've noticed your fork doesn't have an issue tab. I think it would be a must, since the idea is to keep the project updated. I'll try to keep up with your version until this one get's it's attention back, or just keep rolling with yours.

fonsecapontes commented 6 years ago

The author will merge?

akhsunna commented 6 years ago

please do merge

Lizonchik commented 6 years ago

please do merge