anlumo / KaraokeV2

WIP
GNU Affero General Public License v3.0
2 stars 2 forks source link

UI: Language filter doesn't indicate filter status detailed enough #6

Closed MacLemon closed 6 months ago

MacLemon commented 10 months ago

Summary:

UI: Language filter doesn't show if it's applied or set to show ALL

Steps to Reproduce:

Apply language filter for a language

Expected Results:

Icon should somehow indicate that it's being applied for the number of picked languages. For example one, or in the context of #5 how many languages are chosen.

For example by applying a number badge that represents the number of selected languages for the filter.

Actual Results:

Icon stays identical for all states, but only slightly changes in colour. (This colour change was already overseen by a tester.)

HIG:

Regression:

n/a

Notes:

n/a

Version Information:

n/a

anlumo commented 10 months ago

https://api.flutter.dev/flutter/material/Badge-class.html

MacLemon commented 6 months ago

Image

Language filter is properly displayed, even for larger sets.