anoma / taiga

A framework for generalized shielded state transitions
https://anoma.net
GNU General Public License v3.0
138 stars 24 forks source link

bump rust 1.72.0 -> 1.77.0 #259

Closed davidrusu closed 5 months ago

davidrusu commented 5 months ago

Currently main is failing to build on fresh clone:

error: package clap_builder v4.5.2 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.72.0 Either upgrade to rustc 1.74 or newer, or use cargo update -p clap_builder@4.5.2 --precise ver where ver is the latest version of clap_builder supporting rustc 1.72.0

clap_builder has bumped it's MSRV to 1.74. It is pulled in by criterion and vamp-ir:

% cargo tree -i clap_builder
clap_builder v4.5.2
└── clap v4.5.3
    ├── criterion v0.5.1
    │   [dev-dependencies]
    │   └── taiga_halo2 v0.1.0 (/Users/davidrusu/src/taiga/taiga_halo2)
    └── vamp-ir v0.1.3 (https://github.com/anoma/vamp-ir.git?rev=6d401f8a479951727586ef0c44c42edab3139090#6d401f8a)
        └── taiga_halo2 v0.1.0 (/Users/davidrusu/src/taiga/taiga_halo2)

I figured I'd bump rust-version to latest stable version here unless there's a strong reason to use older versions.


Alternatively, if one must stick to 1.72 for some reason, you could pin criterion/vamp-ir to older versions that still compile with rust 1.72.