search

anon-real / ErgoAuctionHouse

Decentralized auction on top of ERGO.
https://ergoauctions.org
MIT License
30 stars 18 forks source link

use picture thumbnails (#23) #24

Open c8e4d2a opened 3 years ago

anon-real commented 3 years ago

@c8e4d2a How about getting gifs from the original source for now and later when you find a way to compress them properly in the server, get the compressed one?

c8e4d2a commented 3 years ago

@c8e4d2a How about getting gifs from the original source for now and later when you find a way to compress them properly in the server, get the compressed one?

Yes. Updated PR with037c020.

anon-real commented 3 years ago

@c8e4d2a I see two problems: 1- For some artworks it says "not found" until it is fully loaded. It is not desired I think because people will think there is no image attacked to the NFT. Previously it showed images as they were loading. 2- Please take a look at this for example: http://localhost:3000/#/auction/specific/5e0b26c3e6ded5b21ce9ea4f1bc4792545ce128a09ee04e9a58dfaad5f6ba1ab seems to have some kind of problem.

c8e4d2a commented 3 years ago

@c8e4d2a I see two problems: 1- For some artworks it says "not found" until it is fully loaded. It is not desired I think because people will think there is no image attacked to the NFT. Previously it showed images as they were loading. 2- Please take a look at this for example: http://localhost:3000/#/auction/specific/5e0b26c3e6ded5b21ce9ea4f1bc4792545ce128a09ee04e9a58dfaad5f6ba1ab seems to have some kind of problem.

great catch, had to clear cache to reproduce, will work on an improvement