anotheria / moskito

Monitoring for Java applications. Complete ecosystem for DevOps. Free & open source
http://www.moskito.org
MIT License
225 stars 69 forks source link

Impossible to create a Threshold or Accumulator while connected to another entity #274

Closed dvayanu closed 10 months ago

dvayanu commented 11 months ago

If we are browsing a remote instance and trying to create an accumulator/threshold there, we won't be able too. It appears that either the remoteLink parameter is not used in the form or not put there or not evaluated.

From here, the dialog opens Screenshot 2023-11-28 at 16 25 07

The dialog Screenshot 2023-11-28 at 16 25 14

The form should have proper setting but it doesn't:

Screenshot 2023-11-28 at 16 25 33

dvayanu commented 11 months ago

This is obviously broken for Accumulator AND Threshold creation, and probably also for Tracer, at least when backjumping from Tracer creation:

net.anotheria.moskito.webui.tracers.action.CreateTracerAction

httpServletResponse.sendRedirect("mskShowProducer?"+PARAM_PRODUCER_ID+ '=' + URLEncoder.encode(producerId, "UTF-8"));

Doesn't have remoteConnection parameter in it.

dvayanu commented 11 months ago

I assume that CreateThresholdAction

return mapping.redirect().addParameter("newThreshold",po.getName()).addParameter("pProducerId", po.getProducerId());

will also fail, but it fails before already

dvayanu commented 10 months ago

The issue was a problem in configuration of nginx prior to moskito-inspect.