anoyetta / ACT.Hojoring

Advanced Combat Tracker の FFXIV向けプラグインです。トリガ、TTSの拡張、HUDの拡張など。
BSD 3-Clause "New" or "Revised" License
288 stars 67 forks source link

Display issue of overlays on systems where decimal point and comma are switched #174

Closed Akurosia closed 6 months ago

Akurosia commented 5 years ago

Describe the bug Some elements are not displayed correctly on systems where decimal point and comma are switched. These include e.g. FFLOGS and Enmity overlay in "ultrascouter > target"

To Reproduce Precondition:

  1. Set decimal point to "," in windows system settings (see attached image)

Steps to reproduce the behavior:

  1. In ACT go to 'Plugins' > 'ULTRA SCOUTER' > 'Target' > 'Enmity'
  2. Make sure that checkboxes for 'Visible' and 'Test Mode' are active and if not activate tham
  3. View the displayed test overlay

Screenshots ApplicationFrameHost_HjkCADVnjo Advanced_Combat_Tracker_fJ693uW3Pp tjUxGHYwM5

Environment

Additional context If changing them on an existing installation of ACT it might break the UI of ACT itself (so please make backups before testing/verifying) Due to potential problems with other programms, changing the decimal point on a system level is not an option in the long run and should be handeled in code.

Akurosia commented 5 years ago

As there was a discussion about a similar issue on the ACT_FFXIV discord (beta-testing channel):

You should use ToString(CultureInfo.InvariantCulture) That will fix it basically defaults to "English"

from the discord user: goat (meeboo #3048)