3/6/24 Pull Request: Notes, Next Steps, Questions

[anschelburk]

Steps Taken:

• Removed commented out code.
• Successfully fixed bug in merge_dict functions for keys that have commas.
• Successfully added drop-down lists to the \'My Ingredients List\' Column. (Along with this: figured out how to give each box a unique key for later reference using a for loop, which took a little time to figure out.)
• Successfully fixed code in add and remove buttons that prevented both the nutrients_i_need and nutrients_i_have dicts from updating when they needed to.

Questions (we can address these asynchronously, or on our next call - totally up to you):

• A green number mirroring the value of each drop-down box is appearing next to it. I spent some time trying unsuccessfully to remove it. Any idea about how I could achieve this?
• Right now, the formatting of the drop-down lists is weird. I spent some time today unsuccessfully trying to fix it. (Separating that column into two subcolumns, but a blank line was generated above each drop-down list, so the text and boxes didn't line up. Trying to create a single line with text and a drop-down box produced errors.) Is there an easy way to fix it? Not urgent, but might be worth looking at.

My Next Steps:

• Fix .env bug (re: the issue you posted).
• Refactor functions so they only modify variables within the function (so they're "pure").
• New Issue: after our call today, it occurred to me that I can address a few of the issues you posted more efficiently by refactoring my code so that results_name and results_nutrients are both part of a larger dict. (Right now, an ingredient's name and nutrients are stored in two separate variables; this would tie those two pieces of info together for each ingredient in a single, larger dict.) This would make the code cleaner, pave the way for the multiplication action of merge_dicts, and allow the user to remove an ingredient without searching using the Search an Ingredient box again. (Otherwise, I'm not sure that would be possible for the user to do.) Rather than posting it in several places on the other page, I'm posting it once here, but please let me know if there's a better/clearer way to post something like this in the future on GitHub.
• If time, refactor merge_dict functions using enum actions, and create a multiplication action for the function.

Thank you for talking earlier. Looking forward to continuing to work on this tomorrow! -AKB

[bbelderbos]

Hey Anschel, great progress, let me address your questions in 2 new issues = easier + better for documentation.

The next actions look good to me.

The refactoring idea, yes it's good to use issues for that as well to quickly confirm and have a track record. Please do that work on a new branch (branches are great for experimental changes) and open a PR at the end of your day today so I can take a look (either completed or where you get stuck if you get stuck). Keep going!

[anschelburk]

Pushed the modified code to GitHub. Following your suggestion, will create new branches for new features.