ansible-collections / ibm.spectrum_virtualize

IBM Spectrum Virtualize
GNU General Public License v3.0
21 stars 27 forks source link

Support additional volume group and snapshot features (info, rename, assign) #92

Closed lszomor closed 1 year ago

lszomor commented 1 year ago
SUMMARY

Hi Would it be possible to add additional features regarding volume groups and snapshots? I'd like to have support for the following features:

We are introducing FlashSystem arrays into our environment. We will depend on these features in our daily operations. I've implemented all the features for our internal use. Please find the links for them in the additional information section.

Thank you!

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Gathering volume group and snapshot information

Commit: https://github.com/lszomor/ibm.spectrum_virtualize/commit/acd2584eb7d45250777e7321c986e1cdbc04b3b0

- name: Get volume group and snapshot info
  ibm.spectrum_virtualize.ibm_svc_info:
    clustername: "{{clustername}}"
    domain: "{{domain}}"
    username: "{{username}}"
    password: "{{password}}"
    log_path: /tmp/ansible.log
    gather_subset: 
      - snapshot
      - volumegroup
Volume group rename capability

Commit: https://github.com/lszomor/ibm.spectrum_virtualize/commit/109058bfd31371473f2065645c5df286960948bc

- name: Rename an existing volume group
  ibm.spectrum_virtualize.ibm_svc_manage_volumegroup:
    clustername: "{{ clustername }}"
    domain: "{{ domain }}"
    username: "{{ username }}"
    password: "{{ password }}"
    log_path: /tmp/playbook.debug
    old_name: vg0
    name: new_vg0_name
    state: present
An override flag to manage a mirrored volume

Commit: https://github.com/lszomor/ibm.spectrum_virtualize/commit/9afe007d9483ed346e65b71af81f1d3b429a897a

- name: Assign a Mirrored volume to a Volume Group
  ibm.spectrum_virtualize.ibm_svc_manage_volume:
    clustername: "{{ clustername }}"
    domain: "{{ domain }}"
    username: "{{ username }}"
    password: "{{ password }}"
    name: "volume_name"
    volumegroup: "test_volumegroup"
    force: true
    state: "present"
Shilpi-J commented 1 year ago

@lszomor svc_info module has been updated in 1.12.0 to support "Gathering volume group and snapshot information"

For 2) point above, will review the changes.

lszomor commented 1 year ago

@Shilpi-J Thank you! I've merged the 1.12.0 release into our other features branches. Our playbooks updated to use version 1.12.0 and working as expected.

Shilpi-J commented 1 year ago

Thanks @lszomor For point 3) above "An override flag to manage a mirrored volume", we have a separate module ibm_svc_manage_mirrored_volume. Did you try this module to manage/configure mirrored volumes and face any issues ?

lszomor commented 1 year ago

Hi @Shilpi-J,

Sorry for the late reply. We are happily using the ibm_svc_manage_mirrored_volume to create HyperSwap volumes. I did not see an option to assign volume group (s) to it. Let me share our use case:

Shilpi-J commented 1 year ago

@lszomor We have fixed this issue. The new code is available at: https://github.com/ansible-collections/ibm.storage_virtualize

Shilpi-J commented 1 year ago

Closing this issue. In case you face any other issue while using the feature, please raise it at: https://github.com/ansible-collections/ibm.storage_virtualize/issues

lszomor commented 1 year ago

@Shilpi-J Thank you! I'll check in the upcoming days.