search

ansible-collections / overview

Collections overview, how to request a namespace
GNU General Public License v3.0
247 stars 49 forks source link

Inclusion: Update wording of temporary files to not count editor files as temporary #215

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

Resolves: https://github.com/ansible-community/community-topics/issues/138

~In a bit of irony, my own editor config has "fixed" some whitespace issues here 😅 so, I've separated the content changes into a separate commit for easier review: aa33de2b21f14ac714966a14962a1bb4eba20be1~ moved to #216

ISSUE TYPE
felixfontein commented 2 years ago

I think it's best to move the whitespace changes to another PR, because that one we can just merge, while this one needs a vote ;-)

briantist commented 2 years ago

I think it's best to move the whitespace changes to another PR, because that one we can just merge, while this one needs a vote ;-)

I could do that if it will be merged in short order and I can rebase this; I'm also fine leaving it in this one (and waiting for the vote). If I remove it from here (without it being merged/rebases) I will have to deal with it every time I save a new change.

felixfontein commented 2 years ago

I could do that if it will be merged in short order and I can rebase this

That should happen :)

briantist commented 2 years ago

@felixfontein

briantist commented 2 years ago

thanks @felixfontein I have rebased and there are no more whitespace-only changes in this PR

briantist commented 2 years ago

@Andersson007 would you like to suggest any changes here?

Andersson007 commented 2 years ago

I'm not sure how to proceed, folks thoughts? option 1: merge it as it just removes confusion option 2: vote in the topics

briantist commented 2 years ago

vote is open!

Andersson007 commented 2 years ago

Thanks @briantist and everyone involved!