ansible-community / antsibull-build

Tooling for building various things related to ansible
GNU General Public License v3.0
60 stars 31 forks source link

✨ Dive into the Enhanced Documentation: Experience the Difference! #634

Closed AryanVBW closed 6 days ago

AryanVBW commented 1 week ago

🎉 Improvements Made to README

🌟 Enhancements

✨ Overall Impact

These improvements make the README more attractive, easier to navigate, and more enjoyable for users, enhancing their experience when using the antsibull project!

oraNod commented 6 days ago

Thanks for the suggested changes @AryanVBW improvements are always welcome.

Unfortunately I think this PR is a combination of several different types of changes that make it difficult to review.

There also seem to be some changes that go against conventions with Ansible projects. For instance, you've replaced the badge links at the top with embedded HTML.

Also the widespread use of the icons seems like a potential accessibility problem.

If you feel like some, or all, of these changes are valid and you would like to contribute them to the project, I would suggest that you break things into separate, atomic commits for ease of review as well as being easy to revert should that become necessary. If you're not familiar with the benefits of atomic commits, please have a look at some of the resources here: https://gist.github.com/webknjaz/a7362787a80067af8621a85a71746ca1

For now I'm going to close this PR but don't interpret that as a rejection of your changes. There are just too many changes here to merge in a single PR. Cheers.