search

ansible / awx-resource-operator

43 stars 34 forks source link

Add support for Container Registry credentials #134

Open the-it-jaeger opened 1 year ago

the-it-jaeger commented 1 year ago

This should help with #130

cooktheryan commented 1 year ago

once #133 goes in this should test properly /cc @rooftopcellist

cooktheryan commented 1 year ago

@the-it-jaeger can you merge in the current main? It should help with testing

rooftopcellist commented 1 year ago

@the-it-jaeger can you please rebase so that the tests pass?

the-it-jaeger commented 1 year ago

@rooftopcellist I think I rebased properly. I'm not very good at this yet, so please bear with me.

cooktheryan commented 1 year ago

@rooftopcellist I'll write a test case for this upon merging

the-it-jaeger commented 1 year ago

Ugh. I pushed additional changes related to EEs to the same branch. What's the best way to un-mess that up?

the-it-jaeger commented 1 year ago

Reverted previous commits. I will make them to another branch and prepare another PR for EE support.

cooktheryan commented 1 year ago

@the-it-jaeger do you want to take a stab at writing the test for it? Example of how they are written are within .github

the-it-jaeger commented 1 year ago

I can take a stab at it next week. I might call for backup if I get stuck 😅. Dev-y stuff is not my wheelhouse, but I'm willing to learn.

the-it-jaeger commented 1 year ago

@cooktheryan looking around, it seems I will need to write another AnsibleCredential manifest with .spec.type: Container Registry, drop it in config/samples/credentials/ and add a kubectl apply -f ... and a kubectl wait ... line here:

https://github.com/ansible/awx-resource-operator/blob/20aa4cc7e09ce3409ee2485cdb269a86f40e2e37/.github/workflows/kind-awx.yaml#L189-L208

Am I on the right track?

cooktheryan commented 1 year ago

@the-it-jaeger 100% correct

the-it-jaeger commented 1 year ago

@cooktheryan : How does this look? ☝️

the-it-jaeger commented 1 year ago

@rooftopcellist will you please have a look when you can?

the-it-jaeger commented 12 months ago

@rooftopcellist any chance you have some time to review this?

the-it-jaeger commented 10 months ago

Bump 😉

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

AaronJaegerVA commented 3 months ago

@cooktheryan @rooftopcellist would either of you be able to review this?

AaronJaegerVA commented 3 months ago

@neevnuv would you take a look at this one? It's been pending for ages.