ant-design / ant-design

An enterprise-class UI design language and React UI library
https://ant.design
MIT License
93.72k stars 51.17k forks source link

fix: pagination a11y test error #52616

Closed aojunhao123 closed 2 weeks ago

aojunhao123 commented 2 weeks ago

๐Ÿค” This is a ...

๐Ÿ”— Related Issues

๐Ÿ’ก Background and Solution

๐Ÿ“ Change Log

Language Changelog
๐Ÿ‡บ๐Ÿ‡ธ English fix: improve pagination accessibility by adding proper ARIA attributes
๐Ÿ‡จ๐Ÿ‡ณ Chinese fix: ้€š่ฟ‡ๆทปๅŠ ้€‚ๅฝ“็š„ ARIA ๅฑžๆ€งๆฅๆ”นๅ–„ๅˆ†้กตๅ™จ็š„ๅฏ่ฎฟ้—ฎๆ€ง
stackblitz[bot] commented 2 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 2 weeks ago

๐Ÿ‘ Visual Regression Report for PR #52616 Failed โŒ

๐ŸŽฏ Target branch: master (a10d54e7461d3b66eb3ff7d84c8134dfaaefbfb4) ๐Ÿ“– View Full Report โ†—๏ธŽ ๐Ÿ“Š Summary: ๐Ÿ”„ 2 changed

Expected (Branch master) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png
list-vertical.dark.png list-vertical.dark.png list-vertical.dark.png list-vertical.dark.png

[!IMPORTANT] There are 2 diffs found in this PR: ๐Ÿ”„ 2 changed. Please check all items:

  • [x] Visual diff is acceptable
github-actions[bot] commented 2 weeks ago

Preview is ready

petercat-assistant[bot] commented 2 weeks ago

Walkthrough

This pull request updates the rc-pagination dependency from version 5.0.0 to 5.1.0 to address a bug fix. It also modifies the accessibility test for pagination by removing the skip condition for simple.tsx, indicating that the issue has been resolved in the new version.

Changes

Files Changed Summary
components/pagination/tests/snapshots/demo-extend.test.ts.snap, components/pagination/tests/snapshots/demo.test.ts.snap Updated snapshot tests to reflect changes in rc-pagination version 5.1.0.
components/pagination/tests/a11y.test.ts Removed skip condition for simple.tsx in accessibility tests, indicating the fix is applied.
package.json Bumped rc-pagination version from 5.0.0 to 5.1.0.
socket-security[bot] commented 2 weeks ago

New, updated, and removed dependencies detected. Learn more about Socket for GitHub โ†—๏ธŽ

Package New capabilities Transitives Size Publisher

๐Ÿšฎ Removed packages: npm/adm-zip@0.5.16, npm/ali-oss@6.22.0, npm/antd-img-crop@4.24.0, npm/antd-style@3.7.1, npm/antd-token-previewer@2.0.8, npm/axios@1.7.9, npm/cheerio@1.0.0, npm/circular-dependency-plugin@5.2.2, npm/classnames@2.5.1, npm/cli-progress@3.12.0, npm/copy-to-clipboard@3.3.3, npm/cross-env@7.0.3, npm/cross-fetch@4.1.0, npm/dayjs@1.11.13, npm/dekko@0.2.1, npm/dotenv@16.4.7, npm/dumi-plugin-color-chunk@1.1.2, npm/dumi@2.4.17, npm/env-paths@3.0.0, npm/eslint-plugin-compat@6.0.2, npm/eslint-plugin-jest@28.11.0, npm/eslint@9.19.0, npm/rc-cascader@3.33.0, npm/rc-checkbox@3.5.0, npm/rc-collapse@3.9.0, npm/rc-dialog@9.6.0, npm/rc-drawer@7.2.0, npm/rc-dropdown@4.2.1, npm/rc-field-form@2.7.0, npm/rc-image@7.11.0, npm/rc-input-number@9.4.0, npm/rc-input@1.7.2, npm/rc-mentions@2.19.1, npm/rc-menu@9.16.0, npm/rc-motion@2.9.5, npm/rc-notification@5.6.2, npm/rc-pagination@5.0.0, npm/rc-picker@4.9.2, npm/rc-progress@4.0.0, npm/rc-rate@2.13.0, npm/rc-resize-observer@1.4.3, npm/rc-segmented@2.7.0, npm/rc-select@14.16.6, npm/rc-slider@11.1.8, npm/rc-steps@6.0.1, npm/rc-switch@4.1.0, npm/rc-table@7.50.2, npm/rc-tabs@15.5.0, npm/rc-textarea@1.9.0, npm/rc-tooltip@6.3.2, npm/rc-tree-select@5.27.0, npm/rc-tree@5.13.0, npm/rc-upload@4.8.1, npm/rc-util@5.44.3, npm/react@19.0.0, npm/scroll-into-view-if-needed@3.1.0, npm/throttle-debounce@5.0.2

View full reportโ†—๏ธŽ

pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

More templates

- [farm-normal](https://pkg.pr.new/template/c370854a-7e69-4d57-9826-cc26653df23f) - [rsbuild-normal](https://pkg.pr.new/template/cff20392-5ea1-48dc-ad1d-d77369135a9e) - [vite-normal](https://pkg.pr.new/template/d7a36cc3-2487-479f-b146-40be69b9d915) - [vite-practice](https://pkg.pr.new/template/e46c1ae2-90a8-4f96-8923-ac71e91a74b6) - [umi-normal](https://pkg.pr.new/template/3a0703cf-3fb2-4d47-8676-2f81ea2107b2) - [with-nextjs-app-router-inline-style](https://pkg.pr.new/template/2f58aa8a-6610-435c-8825-3445454e9199) - [with-nextjs-extract-style](https://pkg.pr.new/template/61ba6e1a-c245-4752-81fc-ce368810a7a4) - [with-nextjs-generate-css-on-demand](https://pkg.pr.new/template/d220af9f-b337-44cf-89c6-8e77cbc64286) - [with-nextjs-inline-style](https://pkg.pr.new/template/d67f6257-34c5-403e-9365-bc182efb477d)

npm i https://pkg.pr.new/ant-design/ant-design/antd@52616

commit: 329c8ea

codecov[bot] commented 2 weeks ago

Bundle Report

Changes will decrease total bundle size by 2 bytes (-0.0%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | antd.min-array-push | 3.37MB | 2 bytes (-0.0%) :arrow_down: |

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push #### **Assets Changed:** | Asset Name | Size Change | Total Size | Change (%) | | ---------- | ----------- | ---------- | ---------- | | ```antd-with-locales.min.js``` | 1 bytes | 1.84MB | -0.0% | | ```antd.min.js``` | 1 bytes | 1.53MB | -0.0% |
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a10d54e) to head (329c8ea). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #52616 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 763 763 Lines 13780 13780 Branches 3609 3609 ========================================= Hits 13780 13780 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.