Closed afc163 closed 2 weeks ago
Run & review this pull request in StackBlitz Codeflow.
🎯 Target branch: master (a10d54e7461d3b66eb3ff7d84c8134dfaaefbfb4) 📖 View Full Report ↗︎ 📊 Summary: 🔄
25
changed
Expected (Branch master) | Actual (Current PR) | Diff |
---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
[!WARNING] There are more diffs not shown in the table. Please check the Full Report for details.
[!IMPORTANT] There are 25 diffs found in this PR: 🔄
25
changed. Please check all items:
- [x] Checked all diffs in the full report
- [x] Visual diff is acceptable
This pull request addresses a bug fix related to the Menu component in the Ant Design library. Specifically, it corrects the text color of submenu items when they are selected, ensuring consistency with the theme settings, particularly in dark mode.
File | Summary |
---|---|
components/menu/style/index.ts | Added subMenuItemSelectedColor to align submenu item text color with darkItemSelectedColor when selected. |
Path | Size |
---|---|
dist/antd.min.js |
441.72 KB (+6 B 🔺) |
dist/antd-with-locales.min.js |
509.91 KB (+3 B 🔺) |
- [farm-normal](https://pkg.pr.new/template/24055c0e-5d6a-4b26-bb9e-4f729369e455) - [vite-normal](https://pkg.pr.new/template/fbf3c27b-4177-440d-b8c7-c18193987d21) - [vite-practice](https://pkg.pr.new/template/1aaddae2-f12d-4875-b594-08a8387021a2) - [umi-normal](https://pkg.pr.new/template/842aafce-4638-4663-9b67-dff52fcd873d) - [with-nextjs-app-router-inline-style](https://pkg.pr.new/template/2d6a14d8-0501-4ce3-b3bd-82aca563c1f9) - [with-nextjs-extract-style](https://pkg.pr.new/template/722c5245-3cb7-4131-ad53-811038192123) - [with-nextjs-generate-css-on-demand](https://pkg.pr.new/template/06362da8-1f13-4b5b-a350-115aaaffc9c5) - [rsbuild-normal](https://pkg.pr.new/template/ec4fd202-bc5b-49b2-b94f-39ef0ddc748b) - [with-nextjs-inline-style](https://pkg.pr.new/template/67c65fd9-6c73-4329-b55d-78b16b48840b)
npm i https://pkg.pr.new/ant-design/ant-design/antd@52617
commit: 0fe6cd8
Changes will increase total bundle size by 54 bytes (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:
Latest commit: |
0fe6cd8
|
Status: | ✅ Deploy successful! |
Preview URL: | https://1d82dc7e.ant-design.pages.dev |
Branch Preview URL: | https://fix-menu-dark-background.ant-design.pages.dev |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
2de4cb2
) to head (0fe6cd8
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
fix https://github.com/ant-design/ant-design/issues/52582
💡 Background and Solution
📝 Change Log
theme="dark"
时水平菜单的文字色和背景色同色的问题。