ant-design / ant-design

An enterprise-class UI design language and React UI library
https://ant.design
MIT License
93.72k stars 51.17k forks source link

fix: Menu submenu selected text color #52617

Closed afc163 closed 2 weeks ago

afc163 commented 2 weeks ago

中文版模板 / Chinese template

🤔 This is a ...

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

fix https://github.com/ant-design/ant-design/issues/52582

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Fix Menu submenu text color when it is selected.
🇨🇳 Chinese 修复 Menu theme="dark" 时水平菜单的文字色和背景色同色的问题。
stackblitz[bot] commented 2 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 2 weeks ago

👁 Visual Regression Report for PR #52617 Failed ❌

🎯 Target branch: master (a10d54e7461d3b66eb3ff7d84c8134dfaaefbfb4) 📖 View Full Report ↗︎ 📊 Summary: 🔄 25 changed

Expected (Branch master) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png
layout-custom-trigger-debug.compact.png layout-custom-trigger-debug.compact.png layout-custom-trigger-debug.compact.png layout-custom-trigger-debug.compact.png
layout-custom-trigger-debug.compact.png layout-custom-trigger-debug.compact.png layout-custom-trigger-debug.compact.css-var.png layout-custom-trigger-debug.compact.css-var.png
layout-custom-trigger-debug.dark.png layout-custom-trigger-debug.dark.png layout-custom-trigger-debug.dark.png layout-custom-trigger-debug.dark.png
layout-custom-trigger-debug.dark.png layout-custom-trigger-debug.dark.png layout-custom-trigger-debug.dark.css-var.png layout-custom-trigger-debug.dark.css-var.png
layout-custom-trigger-debug.default.png layout-custom-trigger-debug.default.png layout-custom-trigger-debug.default.png layout-custom-trigger-debug.default.png
layout-custom-trigger-debug.default.png layout-custom-trigger-debug.default.png layout-custom-trigger-debug.default.css-var.png layout-custom-trigger-debug.default.css-var.png
menu-style-debug.compact.png menu-style-debug.compact.png menu-style-debug.compact.png menu-style-debug.compact.png

[!WARNING] There are more diffs not shown in the table. Please check the Full Report for details.


[!IMPORTANT] There are 25 diffs found in this PR: 🔄 25 changed. Please check all items:

  • [x] Checked all diffs in the full report
  • [x] Visual diff is acceptable
github-actions[bot] commented 2 weeks ago

Preview is ready

petercat-assistant[bot] commented 2 weeks ago

Walkthrough

This pull request addresses a bug fix related to the Menu component in the Ant Design library. Specifically, it corrects the text color of submenu items when they are selected, ensuring consistency with the theme settings, particularly in dark mode.

Changes

File Summary
components/menu/style/index.ts Added subMenuItemSelectedColor to align submenu item text color with darkItemSelectedColor when selected.
github-actions[bot] commented 2 weeks ago

size-limit report 📦

Path Size
dist/antd.min.js 441.72 KB (+6 B 🔺)
dist/antd-with-locales.min.js 509.91 KB (+3 B 🔺)
pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

More templates

- [farm-normal](https://pkg.pr.new/template/24055c0e-5d6a-4b26-bb9e-4f729369e455) - [vite-normal](https://pkg.pr.new/template/fbf3c27b-4177-440d-b8c7-c18193987d21) - [vite-practice](https://pkg.pr.new/template/1aaddae2-f12d-4875-b594-08a8387021a2) - [umi-normal](https://pkg.pr.new/template/842aafce-4638-4663-9b67-dff52fcd873d) - [with-nextjs-app-router-inline-style](https://pkg.pr.new/template/2d6a14d8-0501-4ce3-b3bd-82aca563c1f9) - [with-nextjs-extract-style](https://pkg.pr.new/template/722c5245-3cb7-4131-ad53-811038192123) - [with-nextjs-generate-css-on-demand](https://pkg.pr.new/template/06362da8-1f13-4b5b-a350-115aaaffc9c5) - [rsbuild-normal](https://pkg.pr.new/template/ec4fd202-bc5b-49b2-b94f-39ef0ddc748b) - [with-nextjs-inline-style](https://pkg.pr.new/template/67c65fd9-6c73-4329-b55d-78b16b48840b)

npm i https://pkg.pr.new/ant-design/ant-design/antd@52617

commit: 0fe6cd8

codecov[bot] commented 2 weeks ago

Bundle Report

Changes will increase total bundle size by 54 bytes (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | antd.min-array-push | 3.37MB | 54 bytes (0.0%) :arrow_up: |

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push #### **Assets Changed:** | Asset Name | Size Change | Total Size | Change (%) | | ---------- | ----------- | ---------- | ---------- | | ```antd-with-locales.min.js``` | 27 bytes | 1.84MB | 0.0% | | ```antd.min.js``` | 27 bytes | 1.53MB | 0.0% |
cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0fe6cd8
Status: ✅  Deploy successful!
Preview URL: https://1d82dc7e.ant-design.pages.dev
Branch Preview URL: https://fix-menu-dark-background.ant-design.pages.dev

View logs

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2de4cb2) to head (0fe6cd8). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #52617 +/- ## =========================================== Coverage 100.00% 100.00% =========================================== Files 769 763 -6 Lines 15086 13780 -1306 Branches 4138 3609 -529 =========================================== - Hits 15086 13780 -1306 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.