Closed Brew-Brew closed 7 hours ago
Run & review this pull request in StackBlitz Codeflow.
🎯 Target branch: master (51a213873c99cd1f47cc335d291e57310a0de558) 📖 View Full Report ↗︎ 📖 Alternative Report ↗︎ 📊 Summary: 🔄
1
changed
Expected (Branch master) | Actual (Current PR) | Diff |
---|---|---|
![]() |
![]() |
![]() |
[!IMPORTANT] There are 1 diffs found in this PR: 🔄
1
changed. Please check all items:
- [x] Visual diff is acceptable
This pull request improves the TypeScript definitions by separating the onClick
event types for anchor buttons and regular buttons. This change ensures more precise type handling for button click events, enhancing type safety and clarity in the codebase.
File | Summary |
---|---|
components/button/button.tsx | Modified the onClick event handling to differentiate between anchor and regular buttons, using specific event types for each. |
- [farm-normal](https://pkg.pr.new/template/0cf5d8a3-f0f1-4ffe-a99f-afd72c5404e2) - [rsbuild-normal](https://pkg.pr.new/template/b7727665-47b0-4261-9a50-75fa7fadf17e) - [vite-normal](https://pkg.pr.new/template/13bc2151-98b7-4949-a032-73f42c9dc7b1) - [vite-practice](https://pkg.pr.new/template/730a355c-fd4e-421f-a060-6e166c25ddcf) - [with-nextjs-app-router-inline-style](https://pkg.pr.new/template/69b6ef87-165b-461b-99c8-3ee45af9bb31) - [umi-normal](https://pkg.pr.new/template/1e607750-87c7-47ef-a71f-00290d3735a9) - [with-nextjs-extract-style](https://pkg.pr.new/template/d6b7d8ac-80c3-417b-a651-4a0434ec1bda) - [with-nextjs-generate-css-on-demand](https://pkg.pr.new/template/3c2eb8cf-03c3-455e-8c6b-ee556940a2f4) - [with-nextjs-inline-style](https://pkg.pr.new/template/8939fb8d-0cc2-46b7-8c3f-8f6208d9ded5)
npm i https://pkg.pr.new/ant-design/ant-design/antd@52654
commit: 3e43e33
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
04855cc
) to head (3e43e33
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).
🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log