Closed Jerryqun closed 3 days ago
Run & review this pull request in StackBlitz Codeflow.
🎯 Target branch: master (755cde5792cac4413cf0d312aa1ea2b13be6a512) 📖 View Full Report ↗︎ 📊 Summary: 🔄
5
changed
Expected (Branch master) | Actual (Current PR) | Diff |
---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
[!IMPORTANT] There are 5 diffs found in this PR: 🔄
5
changed. Please check all items:
- [ ] Visual diff is acceptable
This pull request enhances the Rate
component by allowing the tooltips
property to support all Tooltip
props. This change addresses the main issue of enabling full tooltip customization.
Files | Summary |
---|---|
components/rate/demo/text.tsx |
Updated Rate component usage to include tooltipProps for additional customization. |
components/rate/index.en-US.md , components/rate/index.zh-CN.md |
Added documentation for the new tooltipProps property. |
components/rate/index.tsx |
Modified Rate component to accept and apply tooltipProps for tooltips. |
- [farm-normal](https://pkg.pr.new/template/f42fe348-9293-4867-a410-8ae8daa022ae) - [umi-normal](https://pkg.pr.new/template/2befd393-ce89-4c49-8ac2-fef554e5726a) - [rsbuild-normal](https://pkg.pr.new/template/011b349b-2a3a-48d2-9176-c85ce16f5aab) - [vite-normal](https://pkg.pr.new/template/b6210f92-1d93-4ac8-a0b2-6b6c708ffdaa) - [with-nextjs-app-router-inline-style](https://pkg.pr.new/template/024067b3-4a8f-4708-bb6b-fd4511fdae27) - [with-nextjs-extract-style](https://pkg.pr.new/template/b039c0e1-2bc6-4b5b-b46f-c6f7192cd42b) - [vite-practice](https://pkg.pr.new/template/ba873ad9-0fe4-4325-9200-72d0883f2f30) - [with-nextjs-generate-css-on-demand](https://pkg.pr.new/template/c0e7c33e-0911-4c38-9e96-886dc13cae8e) - [with-nextjs-inline-style](https://pkg.pr.new/template/1b7bd2d2-d582-4e6d-932d-4bf9f653d4c8)
npm i https://pkg.pr.new/ant-design/ant-design/antd@52655
commit: b841d28
Changes will increase total bundle size by 588 bytes (0.02%) :arrow_up:. This is within the configured threshold :white_check_mark:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
15bf00d
) to head (62cae08
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
这算是新功能,应该把base换成feature
提交到 next 分支上。
提交到 next 分支上。
已修改
不应该改动 Rate 之外的文件。
提交到 next 分支上。
已修改
携带了其他的 commit,你应该基于 next分支创建这个pr。可以删除本地这个分支,然后基于next分支最新的代码,重新创建这个分支名,然后 git cherry-pick,把你先前的 commit 修改内容pick回来,再推送上去。
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
issues中主问题:
tooltips,应该支持全部的Tooltip props
已修改,其他三点优化看代码是要改rc-rate包,是否可以放另外一个issues help。 如何关联修改,请大佬指点。📝 Change Log