ant-design / ant-design

An enterprise-class UI design language and React UI library
https://ant.design
MIT License
93.39k stars 51.04k forks source link

Rate 的 tooltips属性支持全部的Tooltip props #52655

Closed Jerryqun closed 3 days ago

Jerryqun commented 5 days ago

中文版模板 / Chinese template

🤔 This is a ...

🔗 Related Issues

  • fix #52485

💡 Background and Solution

issues中主问题:tooltips,应该支持全部的Tooltip props已修改,其他三点优化看代码是要改rc-rate包,是否可以放另外一个issues help。 如何关联修改,请大佬指点。

📝 Change Log

Language Changelog
🇺🇸 English Rate component tooltips should support all Tooltip props
🇨🇳 Chinese Rate组件 tooltips,应该支持全部的Tooltip props
stackblitz[bot] commented 5 days ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 5 days ago

👁 Visual Regression Report for PR #52655 Failed ❌

🎯 Target branch: master (755cde5792cac4413cf0d312aa1ea2b13be6a512) 📖 View Full Report ↗︎ 📊 Summary: 🔄 5 changed

Expected (Branch master) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png
rate-text.compact.png rate-text.compact.png rate-text.compact.png rate-text.compact.png
rate-text.compact.png rate-text.compact.png rate-text.compact.css-var.png rate-text.compact.css-var.png
rate-text.default.png rate-text.default.png rate-text.default.png rate-text.default.png
rate-text.default.png rate-text.default.png rate-text.default.css-var.png rate-text.default.css-var.png

[!IMPORTANT] There are 5 diffs found in this PR: 🔄 5 changed. Please check all items:

  • [ ] Visual diff is acceptable
github-actions[bot] commented 5 days ago

Preview is ready

petercat-assistant[bot] commented 5 days ago

Walkthrough

This pull request enhances the Rate component by allowing the tooltips property to support all Tooltip props. This change addresses the main issue of enabling full tooltip customization.

Changes

Files Summary
components/rate/demo/text.tsx Updated Rate component usage to include tooltipProps for additional customization.
components/rate/index.en-US.md, components/rate/index.zh-CN.md Added documentation for the new tooltipProps property.
components/rate/index.tsx Modified Rate component to accept and apply tooltipProps for tooltips.
pkg-pr-new[bot] commented 5 days ago

Open in Stackblitz

More templates

- [farm-normal](https://pkg.pr.new/template/f42fe348-9293-4867-a410-8ae8daa022ae) - [umi-normal](https://pkg.pr.new/template/2befd393-ce89-4c49-8ac2-fef554e5726a) - [rsbuild-normal](https://pkg.pr.new/template/011b349b-2a3a-48d2-9176-c85ce16f5aab) - [vite-normal](https://pkg.pr.new/template/b6210f92-1d93-4ac8-a0b2-6b6c708ffdaa) - [with-nextjs-app-router-inline-style](https://pkg.pr.new/template/024067b3-4a8f-4708-bb6b-fd4511fdae27) - [with-nextjs-extract-style](https://pkg.pr.new/template/b039c0e1-2bc6-4b5b-b46f-c6f7192cd42b) - [vite-practice](https://pkg.pr.new/template/ba873ad9-0fe4-4325-9200-72d0883f2f30) - [with-nextjs-generate-css-on-demand](https://pkg.pr.new/template/c0e7c33e-0911-4c38-9e96-886dc13cae8e) - [with-nextjs-inline-style](https://pkg.pr.new/template/1b7bd2d2-d582-4e6d-932d-4bf9f653d4c8)

npm i https://pkg.pr.new/ant-design/ant-design/antd@52655

commit: b841d28

codecov[bot] commented 5 days ago

Bundle Report

Changes will increase total bundle size by 588 bytes (0.02%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | antd.min-array-push | 3.37MB | 588 bytes (0.02%) :arrow_up: |

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push #### **Assets Changed:** | Asset Name | Size Change | Total Size | Change (%) | | ---------- | ----------- | ---------- | ---------- | | ```antd-with-locales.min.js``` | 360 bytes | 1.84MB | 0.02% | | ```antd.min.js``` | 228 bytes | 1.53MB | 0.01% |
codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (15bf00d) to head (62cae08).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #52655 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 763 763 Lines 13781 13781 Branches 3610 3610 ========================================= Hits 13781 13781 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OysterD3 commented 3 days ago

这算是新功能,应该把base换成feature

afc163 commented 3 days ago

提交到 next 分支上。

Jerryqun commented 3 days ago

提交到 next 分支上。

已修改

afc163 commented 3 days ago
图片

不应该改动 Rate 之外的文件。

thinkasany commented 3 days ago

提交到 next 分支上。

已修改

携带了其他的 commit,你应该基于 next分支创建这个pr。可以删除本地这个分支,然后基于next分支最新的代码,重新创建这个分支名,然后 git cherry-pick,把你先前的 commit 修改内容pick回来,再推送上去。 image