antarctica / PolarRoute

Long-distance maritime polar route planning, taking into account complex changing environmental conditions.
https://antarctica.github.io/PolarRoute/
MIT License
17 stars 3 forks source link

Zero Currents Addition & Minor CLI Bug #259

Closed Ulvetanna closed 7 months ago

Ulvetanna commented 8 months ago

PolarRoute Pull Request Template

Description of change

Making changes to include a zero_currents flag that works from the config_route input. In addition fixing CLI bug with Dijkstra path definition

Testing

To ensure that the functionality of the PolarRoute codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md. This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

list which files have been altered and include a pytest.txt file for each of the tests required to be run

The files which have been changed during this PR can be listed using the command

git diff --name-only 0.3.x

include pytest.txt file showing which tests fail.
include reasoning as to why your changes cause these tests to fail.

Should these changes be valid, relevant test files should be updated.
include pytest.txt file of test passing after test files have been updated.

Checklist

hjabbot commented 8 months ago

Also can you run the tests/regression_tests/test_routes_dijkstra.py and tests/regression_tests/test_routes_smoothed.py tests for this PR? The testing strategy is a bit dated and misleading, but both of these tests make sense to run for this PR

Ulvetanna commented 7 months ago

Please find attached the logs for the two requested tests, completed after final commit above.

dijkstra_test.log smoothed_test.log