Closed gecoombs closed 1 month ago
Ulvetanna
commented
1 month ago Trying a fresh install and environment to test how Fiona dependency would be. Fiona is fine so my comments above can be disregarded.
However, in the setup.py there is a deprecation that should be dealt with. See attached picture
Ulvetanna
commented
1 month ago From running the examples in the repo, one of the traveltime config variables is still required. This variable should be autos in PolarRoute if it's not defined in the config.
gecoombs
commented
1 month ago Trying a fresh install and environment to test how Fiona dependency would be. Fiona is fine so my comments above can be disregarded.
However, in the setup.py there is a deprecation that should be dealt with. See attached picture
Which command did you run to install when you got this warning? Was it python setup.py develop or pip install -e ?
gecoombs
commented
1 month ago From running the examples in the repo, one of the traveltime config variables is still required. This variable should be autos in PolarRoute if it's not defined in the config.
Good catch, I thought I had set this to a default value but there was a bug (copy and paste error :facepalm: ) that caused that to fail. Should be working as of 284a086
Ulvetanna
commented
1 month ago Trying a fresh install and environment to test how Fiona dependency would be. Fiona is fine so my comments above can be disregarded. However, in the setup.py there is a deprecation that should be dealt with. See attached picture
Which command did you run to install when you got this warning? Was it
python setup.py developorpip install -e?
George having a look into gauge how long it would take to change to a newer format
gecoombs
commented
1 month ago I have now pinned the MeshiPhi version in requirements.txt to the current latest release and updated the PolarRoute version number from v0.6 to v1.0 as discussed last week. I spent some time looking at the deprecation warning highlighted above and have made some notes on #298. This needs to be resolved before early next year when a new version of pip will remove compatibility with our current approach but we should be able to address it as part of a hotfix, so that it does not hold up this PolarRoute release.
I also re-ran the regression tests with the latest changes and have posted the results above.
JimCircadian
commented
1 month ago Well done AMOP team 🚀
gecoombs
commented
1 month ago Merging without approval from @hjabbot as he's not currently available and his comments above have been addressed.
PolarRoute Pull Request
Date: 17/09/24 Version Number: 0.5.2 -> 1.0.0
Description of change
Testing
Test results: full_test_log_031024.txt
Files changed:
Checklist