search

antedebaas / Viesti-Reports

DMARC & SMTP-TLS Reports processor and visualizer and BIMI file hoster
https://docs.viestireports.com/
GNU General Public License v2.0
79 stars 16 forks source link

Update base.html.twig to correctly load style.css when project is installed under a subdirectory #141

Closed rvd0167 closed 2 months ago

rvd0167 commented 2 months ago

Make style.css loadable even if the project is installed under a subdirectory.

antedebaas commented 2 months ago

If you have a solution that includes not breaking other parts of the project I’m open to it. See my comment here https://github.com/antedebaas/Viesti-Reports/issues/137#issuecomment-2275065320

rvd0167 commented 2 months ago

Hi

I did make a pull request with this solution. I did not break anything when installed on its own domain. And it is just for style.css. .htaccess is already prepared for subdomain use with the BASE variable. It is stated as such in the .htaccess file

Ron

14 aug 2024 21:00:45 Ante de Baas @.***>:

If you have a solution that includes not breaking other parts of the project I’m open to it. See my comment here #137 (comment)[https://github.com/antedebaas/Viesti-Reports/issues/137#issuecomment-2275065320]

— Reply to this email directly, view it on GitHub[https://github.com/antedebaas/Viesti-Reports/pull/141#issuecomment-2289613333], or unsubscribe[https://github.com/notifications/unsubscribe-auth/BKMJ2TBLBJOOVIGNKJK5M5TZROSN3AVCNFSM6AAAAABMQNJ726VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGYYTGMZTGM]. You are receiving this because you authored the thread. [Tracking afbeelding][https://github.com/notifications/beacon/BKMJ2TGNWCPT7ZHT4QPBPSTZROSN3A5CNFSM6AAAAABMQNJ726WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUIPC5BK.gif]

antedebaas commented 2 months ago

the problem comes when running this in a subdirectory in the first place. The subdirectory will add to the path thus breaking all the policy, autoconfig and bimi hosting. As those have fixed paths in their standards.

the .htaccess is a symfony default one and will not work on other servers like NGINX and ISS thus you can not rely on that.

If you can find a solution for these problems I can consider this

rvd0167 commented 2 months ago

For a solution am I "allowed" to edit .env.local or is that route a no-go?

14 aug 2024 23:10:54 Ante de Baas @.***>:

the problem comes when running this in a subdirectory in the first place. The subdirectory will add to the path thus breaking all the policy, autoconfig and bimi hosting. As those have fixed paths in their standards.

the .htaccess is a symfony default one and will not work on other servers like NGINX and ISS thus you can not rely on that.

If you can find a solution for these problems I can consider this

— Reply to this email directly, view it on GitHub[https://github.com/antedebaas/Viesti-Reports/pull/141#issuecomment-2289910904], or unsubscribe[https://github.com/notifications/unsubscribe-auth/BKMJ2TBR2XJDE62RDB3RV7LZRPBV5AVCNFSM6AAAAABMQNJ726VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZHEYTAOJQGQ]. You are receiving this because you authored the thread. [Tracking afbeelding][https://github.com/notifications/beacon/BKMJ2TEGVPLTYBF67RNX3ZDZRPBV5A5CNFSM6AAAAABMQNJ726WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUIPVCHQ.gif]

antedebaas commented 2 months ago

I fail to see what .env.local has to do with this. im also not telling you what to do or not to do with your copy of the projects code

rvd0167 commented 2 months ago

Just because I had an idea for a completely different approach. Will give it a shot.

14 aug 2024 23:27:37 Ante de Baas @.***>:

I fail to see what .env.local has to do with this. im also not telling you what to do or not to do with your copy of the projects code

— Reply to this email directly, view it on GitHub[https://github.com/antedebaas/Viesti-Reports/pull/141#issuecomment-2289935507], or unsubscribe[https://github.com/notifications/unsubscribe-auth/BKMJ2TENFW5FR7XE5BS2PF3ZRPDUTAVCNFSM6AAAAABMQNJ726VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZHEZTKNJQG4]. You are receiving this because you authored the thread. [Tracking afbeelding][https://github.com/notifications/beacon/BKMJ2THOCANBFU26EZOQ333ZRPDUTA5CNFSM6AAAAABMQNJ726WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUIPWSJG.gif]