search

antek-drzewiecki / wine_bouncer

A Ruby gem that allows Oauth2 protection with Doorkeeper for Grape Api's
MIT License
112 stars 58 forks source link

support grape 1.3.0 #80

Closed alexmamonchik closed 2 years ago

alexmamonchik commented 4 years ago

grape was released 8 days ago, but I can't upgrade it because wine_bouncer locked to grape (< 1.3, >= 0.10)

sdfreund10 commented 4 years ago

I recently ran into this problem too. grape 1.2.x is incompatible with rack >2.0.8 (see this issue https://github.com/ruby-grape/grape/issues/1966). Grape is not specifying this dependency and instead released a 1.3 version with a fix. It seems like either wine_bouncer should be made compatible with grape 1.3 or a rack <2.0.8 dependency should be added. I'm not really sure what the best solution is going forward 😕. For now, I'd recommend anyone using wine_bouncer to version lock rack

antek-drzewiecki commented 4 years ago

I've used a passive lock strategy, to ensure it is tested against the released versions. The side effect is that people cant upgrade that fast. I think we could release the locks .

sarojkh commented 4 years ago

@antek-drzewiecki Any reason this has not been released as a gem?

Thanks for the hard work!

jacek213 commented 3 years ago

Bump

antek-drzewiecki commented 2 years ago

Cleaning up and closing issue. Support had been added.