Incorrect login user is remembered and cannot be removed

[adsbot[bot]]

Issue Type: Bug

My employer has an Azure SQL DB. Originally, all devs connected to this DB using a shared SQL login named "Developer". Later policies were improved and each dev was assigned their own SQL login (mine is called "ian") and the Developer login's password was changed.

When I first connected to Azure SQL using ADS, I used the Developer login and ticked the "Remember password" box. But since I now have to use my own account, I login with ian and my own password, again choosing to have my credentials remembered.

The bug: ADS only remembers the Developer login, not ian. Which means that every time I try to connect to the DB, I am told "login failed for user Developer" and have to type in my ian login.

Second part of the bug: When I type ian in the login box, the password that was supposedly remembered is not filled in.

This is... extremely annoying, to say the least.

SQL Server Management Studio gets this right:

1. It actually remembers all login/password combinations and allows you to select a login via a dropdown, which auto-fills the saved password for that login.
2. It allows logins to be updated or removed via the login dialog, as well as via Windows Credential Manager.

Login functionality is really the absolute most basic feature of any app that you need to have 100% working before you even consider shipping an alpha, and the fact that it doesn't Just Work in ADS is incredibly disappointing. This sort of lack of quality is something I'd expect from a startup, not a multibillion-dollar company like Microsoft. I don't mind testing your software for you, I do mind when it doesn't work any better than the software that already exists (SSMS).

Simplest fix: tell me where/how I can delete saved credentials from ADS. I'd prefer to only delete the Developer login, but if the only option is getting rid of all of them, I can handle it.

Better fix: make the damn login functionality work like it should.

Best fix/feature request: some sort of UI to view all credentials grouped by DB server, with the option to add, remove and set a specific login as default.

Azure Data Studio version: azuredatastudio 1.13.0 (cacd481bff25c890e4130aee392569bae43b7e60, 2019-11-02T00:40:05.147Z) OS version: Windows_NT x64 10.0.18362

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8550U CPU ! 1.80GHz (8 x 1992)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.90GB (2.77GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|

Extensions (2)

Extension|Author (truncated)|Version ---|---|--- ssmskeymap|kev|1.1.0 profiler|Mic|0.9.0

[adstestbot[bot]]

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Feature: Change password of expired login (#605)
• every open the application must login again (#2413)
• Make Azure login entry points more discoverable (#2961)