Open progressionnetwork opened 1 year ago
It is not sufficient to do this without doing more adequate handling of interactive mode. I don't have enough knowledge of the current code to propose major changes, nor do I have time to study it.
Still, I had some discussion about this project, but it was posted in Russian chat. I'm not up to proposing PR here, or even creating a correct Issue (since I would have to double-check everything, but I don't even have a compiler installed!) All I can do is to share my thoughts; it is Russian, but Google Translate converts this to English quite fine:
@aleksusklim which forum is this being discussed?
which forum is this being discussed?
Some random Telegram chat, with no actual coders in it, unfortunately.
(But they are trying to convince me to create either a proper Issue, or even fork the project to fix everything. Despite there are already repos like https://github.com/PotatoSpudowski/fastLLaMa, which I didn't tried yet; and anyway, I don't believe that changing scanf buffer size from hardcoded 256 bytes is something outstanding…)
https://github.com/antimatter15/alpaca.cpp/blob/c5ae5d08a56b82c17ef8121bc01221924576ad28/chat.cpp#L1044-L1047 to
🤦♂️🤦♂️🤦♂️
Originally posted by @aleksusklim in https://github.com/antimatter15/alpaca.cpp/issues/97#issuecomment-1479062604