Closed merklefruit closed 11 months ago
Should we put this config option in the stack.toml?
I definitely think the option should be in the stack toml config. Now that I think about it - could probably also add a configurable (as maybe another field like monorepo_url
) to allow for someone to effectively "point" at a different monorepo - this is useful in modified fork cases for example. This should probably be done under a [monorepo]
toml table. The monorepo toml table would also contain the aforementioned source=tarball | git
field. Though the isolate = true
field for github monorepos should probably still live under a [stages]
table.
This PR adds the following dependencies: curl, tar. AFAIK they come preinstalled with all Unix systems though. we could use the curl crate which embeds the libcurl bindings for us, I don't think that's necessary for now.
I think for this, we should just make a note in the https://github.com/anton-rs/op-up/issues/7 issue which I started to implement in the Dependency manager pr #36
Does this also fix this issue too? https://github.com/anton-rs/op-up/issues/56
Does this also fix this issue too? #56
Not yet, I'm gonna add this in now
Improves the UX of using op-up by downloading a compressed archive instead of cloning the op monorepo. The directory source is set to
MonorepoSource::Tarball
by default, but in the future this can be extended.curl
,tar
. AFAIK they come preinstalled with all Unix systems thoughlibcurl
bindings for us, I don't think that's necessary for nowI tested the download with this test:
But it's a silly test to keep because it would download stuff on every test run – so I removed it from the pr.