feat(Unicon): add hover-fill property

antonreshetov / vue-unicons

1000+ Pixel-perfect svg icons for your next project as Vue components

https://antonreshetov.github.io/vue-unicons/

MIT License

1k stars 56 forks source link

feat(Unicon): add hover-fill property #45

Closed E1mir closed 3 years ago

E1mir commented 3 years ago

Thank you for your contribution to the vue-unicons repo. Before submitting this PR, please make sure:

[X] Your code builds clean without any errors or warnings
[x] Your commits follow the сonvention

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[X] Feature
[ ] Refactor

Importantly

To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on PR.

leyenda commented 3 years ago

Hello, this PR broke the reactivity of the fill prop. Now we cant change the icon fill from the parent, after icon mounted.

E1mir commented 3 years ago

You mean, change via css or what? Could you show me where it happens, and I will try to fix that asap

antonreshetov commented 3 years ago

@leyenda It's not quite clear what we're talking about. P.S. merged PR is not a good place for discussion. Please open an Issue on this subject and provide an example.

leyenda commented 3 years ago

Thank you for your responses, I'll open a new issue to make it more clear.