Closed phigas closed 9 months ago
I'll be slowly checking and will write some ideas/feedback/plans here. So some non-critical things, but generally:
is_something
or has_something
objects are expected to return boolean. In our case, is_inside
returns a string, which is not even used that much, or None, which might also be confusing. In the future, I'll try to standardize that part, so that is_inside
returns True/False, while the place of scattering like right side
is obtained with an additional little function is_right_side()
or something like that.Please check https://anufrievroman.gitbook.io/freepaths/advanced-tutorials/adding-your-own-hole-or-pillar for an explanation of how the refractored holes work
Sorry, missed this PR somehow. Thank you for the huge work. I'll check this week.