anufrievroman / waypaper

GUI wallpaper manager for Wayland and Xorg Linux systems
https://anufrievroman.gitbook.io/waypaper
GNU General Public License v3.0
277 stars 11 forks source link

post_command $wallpaper doesn't work properly if spaces are in filename #36

Closed enjoyerofcode closed 4 months ago

enjoyerofcode commented 4 months ago

When a wallpaper has a space in it's filename $wallpaper doesn't treat it as a whole string and treats it as separate arguments. wallpaper = /path/to/wall paper.png post_command = wallust run $wallpaper In this scenario the command it runs will be wallust run /path/to/wall paper.png (all wallust gets is /path/to/wall), which will make the command not work correctly as it doesn't know the full path to the wallpaper. I would imagine a fix to this would just be to wrap it in quotes so it's treated as a string and not separate arguments, ie: wallust run "/path/to/wall paper.png" which will work properly as wallust will know it's a string.

anufrievroman commented 4 months ago

To me it's more a problem of wallrust that it doesn't understand the path with spaces. If I wrap in quotes the path for everyone, some other programs might not like the quotes, so I am not sure about this solution. Could you please try just writing your post command as wallust run " $wallpaper " ? If that does not work because of the spaces, then I'll try to improve $wallapaper handling.

enjoyerofcode commented 4 months ago

Yeah adding spaces makes it not work properly. Also this isn't just an issue with wallust, this is an issue with pywal as well, and I imagine it breaks a lot of other programs. It doesn't really matter that much because you can just take the spaces out of the filename but it's kind of annoying to have to do that because most other programs support spaces in filenames. Maybe instead of wrapping it in quotes just look if the string has spaces or other special characters and put and backslash behind all of them, that shouldn't break any programs.

anufrievroman commented 4 months ago

Good idea! Just fixed it the way you suggested. It works for me now. Please try by installing from the main branch of from AUR

enjoyerofcode commented 4 months ago

Thank you this works!