anufrievroman / waypaper

GUI wallpaper manager for Wayland and Xorg Linux systems
https://anufrievroman.gitbook.io/waypaper
GNU General Public License v3.0
396 stars 27 forks source link

added new swww transition menu feature. #92

Closed Sandesh2007 closed 1 week ago

Sandesh2007 commented 2 weeks ago

This change adds new swww transition menu feature and added translation for changes done to the feature's tooltop.

Signed-off-by: Sandesh2007 sandeshsharma924@gmail.com

anufrievroman commented 2 weeks ago

Hi, thank you for your work! I'll try review the PR in a few days. In general, I was actually thinking to make a second line of buttons/options specific to swww. Like other transition related options all in one line below the main line of buttons that are common for all backends. If, by chance, you know how to make a new line of buttons for your swww transition button then it would be great to make it that way. If not, it's okay, I'll try to work on it in the near future.

Sandesh2007 commented 2 weeks ago

sure i will give it a shot :)

Sandesh2007 commented 2 weeks ago

Done. Added new menu to set different options for swww backend.

Sandesh2007 commented 2 weeks ago

I forgot to add screenshot :

screenshot2.jpg

anufrievroman commented 1 week ago

Sorry, I still didn't have time to test it, will try to do within a week

Sandesh2007 commented 1 week ago

Sure, I will wait for your response. This is the first time i am contributing to a open source project and this project really helped me to learn making apps for linux in python Gtk. Thank you :)

anufrievroman commented 1 week ago

Hi, I am working on your PR, it looks pretty good, but you should do the changes related to the search bar in a separate branch because all the commits related to that are now also added here, to this PR, which makes it a bit difficult. If you could roll back changes in your main branch to the moment before the search bar, and add all search-bar commits on the separate branch, it would be great. If you aren't sure how to do that, may I can then wait when you complete the search bar as well.

Sandesh2007 commented 1 week ago

I have completed the search bar, but there is the keybinding problem.(searching images also triggers the keybinds) I will try to fix it if i could. I am new to this it would be great if you could tell what should i change.

anufrievroman commented 1 week ago

The quick solution I can think of, is you create a global variable like seach_state = True which activates when the widget is active, and then this variable is checked in on_key_pressed() function, like:

if search_state:
    return

So that the other key bindings are not triggered.

Or maybe, another way, the on_key_pressed() function can simply check if search bar is empty, before continuing.

Sandesh2007 commented 1 week ago

Thanks i was confused on how to fix it, but now it is done.

when the search bar is focused, the keybinding will not work and clicking on the clear button will remove focus from button and the key binding will work.

i will commit the changes in few minutes.

anufrievroman commented 1 week ago

Thank you again, I'll try to check it today.

anufrievroman commented 1 week ago

By the way, I finally decided to rearrange the UI a bit, so I put all the folder related buttons in the top, and then I could put all backend related options, including transitions, into the bottom row.