search

anukat2015 / elda

Automatically exported from code.google.com/p/elda
0 stars 0 forks source link

silence on &param= with no value #175

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

have a query parameter bound to no string, .../segment?foo=

What is the expected output? What do you see instead?

expected: Expect an error 400 or silently ignored (pick one)

actual: no error, but there is DEBUG log output (which is not much
help to the end user)

Original issue reported on code.google.com by ehog.he...@googlemail.com on 19 Jul 2013 at 10:05

GoogleCodeExporter commented 8 years ago 
Please *don't* make it 4xx in this circumstance. The search form on the xslt 
transform produces a full set and more of ¶meters with no value.

Log level DEBUG seems appropriate.

Original comment by skwli...@gmail.com on 19 Jul 2013 at 4:06

GoogleCodeExporter commented 8 years ago 
OK, I wasn't aware of that. Then we officially licence that query
parameters present but with no value are just ignored.

In fact (although I will not change it today) I'd just drop the log message
completely. We allow it, so we don't need to log that we're allowing it.
The implementor won't need to change anything, so there's no need for
a hint about a (non-) problem.

Chris "allusive" Dollin

Original comment by ehog.he...@googlemail.com on 19 Jul 2013 at 4:19