anurag16 / Twitter-Client-with-Fragments

0 stars 0 forks source link

Twitter Client with Fragments #1

Open anurag16 opened 10 years ago

anurag16 commented 10 years ago

@nesquena

nesquena commented 10 years ago

As always, please upload GIF walkthrough and reply back here ASAP

anurag16 commented 10 years ago

Hi Nathan, Uploaded GIF.

Thanks, Anurag

On Mon, Jun 30, 2014 at 11:56 PM, Nathan Esquenazi <notifications@github.com

wrote:

As always, please upload GIF walkthrough and reply back here ASAP

— Reply to this email directly or view it on GitHub https://github.com/anurag16/Twitter-Client-with-Fragments/issues/1#issuecomment-47622882 .

anurag16 commented 10 years ago

Also, have a question. A big chunk of my time doing this assignment was spent in finding solution to a blank home timeline screen that I ended up on every few mins. The error that I saw most was "requestLayout() improperly called by android.widget.RelativeLayout{b328ffe0 V.E..... ......ID 0,0-188,79

7f080012 app:id/ptr_id_header} during layout: running second layout pass".

This was a blocker every time as nothing on the UI can be done unless I get to the bare tweet list view.

Can you please suggest what might be the cause of this error?

Thanks, Anurag

On Tue, Jul 1, 2014 at 12:20 AM, Anurag Gupta anurag.gupta.usc@gmail.com wrote:

Hi Nathan, Uploaded GIF.

Thanks, Anurag

On Mon, Jun 30, 2014 at 11:56 PM, Nathan Esquenazi < notifications@github.com> wrote:

As always, please upload GIF walkthrough and reply back here ASAP

— Reply to this email directly or view it on GitHub https://github.com/anurag16/Twitter-Client-with-Fragments/issues/1#issuecomment-47622882 .

nesquena commented 10 years ago

Good to see you got some styling in and a few optionals! :+1: Project looks good. I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.

Can you please suggest what might be the cause of this error?

That error has nothing to do with it. Can you read Problem #2: http://courses.codepath.com/courses/intro_to_android/week/3#!hints I think you are referring to the twitter rate limit?

anurag16 commented 10 years ago

Hi Nathan, This is regarding the problem I faced and wanted to get some info. The issue is that as soon as this warning comes up I am not able to switch between the tabs on timeline activity. Ex - If I am on HomeTimeline and switch to Mentions timeline or vice versa after I have done the switch successfully for a first few times the view does not changes. So if the list before warning was mentions it remains mentions if I switch the tab to home timeline or vice versa. Sometimes the list after the warning ends u being empty even though the data is getting pulled from twitter API.

Did some googling and found out that the call to requestLayout are overlapping when doing the switch causing the issue to happen. Have you seen this earlier? How can we fix it as am not able to find a solution yet.

Thanks, Anurag

On Tue, Jul 1, 2014 at 12:28 AM, Nathan Esquenazi notifications@github.com wrote:

Good to see you got some styling in and a few optionals! [image: :+1:] Project looks good. I have provided a detailed Project 4 Feedback Guide here https://gist.github.com/nesquena/d88cf3606a308359323f which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.

Can you please suggest what might be the cause of this error?

That error has nothing to do with it. Can you read Problem #2: http://courses.codepath.com/courses/intro_to_android/week/3#!hints I think you are referring to the twitter rate limit https://dev.twitter.com/docs/rate-limiting/1.1?

— Reply to this email directly or view it on GitHub https://github.com/anurag16/Twitter-Client-with-Fragments/issues/1#issuecomment-47625100 .

nesquena commented 10 years ago

@anurag16 never ever make a view static https://github.com/anurag16/Twitter-Client-with-Fragments/blob/master/src/com/codepath/apps/simpletwitter/fragments/TweetListFragment.java#L31. The second you make any view instance variable static, bad things happen. Why did you set that static, out of curiosity?

anurag16 commented 10 years ago

Totally missed this reply from you. I removed static but still same problem. I used static for the same reason as any other static variable. Will try more and update, right now focusing on group project.

NOTE: Regarding the question I asked yesterday in class for Video not working. After trying various things all in vain, I tried using a different version for emulator. Was using "Nexus S". Changed to "Nexus 4" and the videos work now. Compatibility issue I suppose?

Thanks, Anurag

On Tue, Jul 1, 2014 at 3:11 PM, Nathan Esquenazi notifications@github.com wrote:

@anurag16 https://github.com/anurag16 never ever make a view static https://github.com/anurag16/Twitter-Client-with-Fragments/blob/master/src/com/codepath/apps/simpletwitter/fragments/TweetListFragment.java#L31. The second you make any view instance variable static, bad things happen. Why did you set that static, out of curiosity?

— Reply to this email directly or view it on GitHub https://github.com/anurag16/Twitter-Client-with-Fragments/issues/1#issuecomment-47715745 .

nesquena commented 10 years ago

It's possible, it could also just be a simple emulator issue, Nexus S definitely should support mp4 videos. You may want to consider switching to the genymotion emulator as well.