search

anuraghazra / github-readme-stats

:zap: Dynamically generated stats for your github readmes
https://github-readme-stats.vercel.app
MIT License
67.54k stars 22.07k forks source link

Add gist card `card_width` argument #3370

Open rickstaa opened 10 months ago

rickstaa commented 10 months ago

Is your feature request related to a problem? Please describe.

We currently do not provide a way to set the card with the gist card while this option is available for the stats and language card.

Describe the solution you'd like

Adding the card_width argument to the gist card endpoint would be nice.

Describe alternatives you've considered

No response

Additional context

When this feature has been implemented and #3359 has been merged the card_width option can be moved to the https://github.com/anuraghazra/github-readme-stats?tab=readme-ov-file#common-options.

Mohammad-Shahid-07 commented 10 months ago

can this issue be assigned to me?

rickstaa commented 10 months ago

can this issue be assigned to me?

Hey @Mohammad-Shahid-07, It is fantastic that you want to contribute to our projects. I assigned you! You can find the changes needed in #https://github.com/anuraghazra/github-readme-stats/pull/3359, which adds the same feature to the repo card 👍🏻. I am looking forward to your pull request.

rickstaa commented 9 months ago

@Mohammad-Shahid-07 It looks like @yaten2302 already implemented this feature. As It looks like you haven't yet started working on it, I will accept #3405 as an entry.

Mohammad-Shahid-07 commented 9 months ago

Sorry this was my first every try and I couldn't understand what to do and i got confused as the same was showing as closed from the link that was given there. Thank you very much for giving me the opportunity.

On Mon, 30 Oct 2023, 3:52 pm Rick Staa, @.***> wrote:

@Mohammad-Shahid-07 https://github.com/Mohammad-Shahid-07 It looks like @yaten2302 https://github.com/yaten2302 already implemented this feature. As It looks like you haven't yet started working on it, I will accept #3405 https://github.com/anuraghazra/github-readme-stats/pull/3405 as an entry.

— Reply to this email directly, view it on GitHub https://github.com/anuraghazra/github-readme-stats/issues/3370#issuecomment-1784886861, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2YIU47TCV2WH3IBMB6PNZDYB55X3AVCNFSM6AAAAAA6CEGQ66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUHA4DMOBWGE . You are receiving this because you were mentioned.Message ID: @.***>

rickstaa commented 9 months ago

Sorry this was my first every try and I couldn't understand what to do and i got confused as the same was showing as closed from the link that was given there. Thank you very much for giving me the opportunity. … On Mon, 30 Oct 2023, 3:52 pm Rick Staa, @.> wrote: @Mohammad-Shahid-07 https://github.com/Mohammad-Shahid-07 It looks like @yaten2302 https://github.com/yaten2302 already implemented this feature. As It looks like you haven't yet started working on it, I will accept #3405 <#3405> as an entry. — Reply to this email directly, view it on GitHub <#3370 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2YIU47TCV2WH3IBMB6PNZDYB55X3AVCNFSM6AAAAAA6CEGQ66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUHA4DMOBWGE . You are receiving this because you were mentioned.Message ID: @.>

No problem at all. I can fully understand. The codebase became quite big after all those years 😅.