anusii / solidpod

MIT License
1 stars 2 forks source link

Av/216 solidpod release v0.6.0 #221

Closed anushkavidanage closed 3 months ago

anushkavidanage commented 4 months ago

Pull Request Details

What issue does this PR address

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

Finalising

Once PR discussion is complete and 2 reviewers have approved:

cdawei commented 3 months ago

I've tested the branch av/216_solidpod_release_v1.0.0 using the solid server (v7.1.0) on dev.empwr.au. Most of the functions of demopod worked, and the Login button respects the server url manullay specified (e.g., solid.dev.empwr.au).

However, if I click Forget Remote Server Login and then Show Pod Data File, the popup login still uses pods.solidcommunity.au (which is the default server) as shown below. Do we need an UI element for users to specify the solid server url for popup login?

image

srodriguez142857 commented 3 months ago

Please check the following screen recordings:

srodriguez142857 commented 3 months ago

I have the following observations/comments:

I still haven't gone over all the features. The observations/comments are mild. If critical, I can approve, and we can merge the changes. Also, we can have a short session where I test the app with Anushka or Dawei and check the behaviours. As a new user, I might do things differently... 🙂

anushkavidanage commented 3 months ago

Thanks Sergio. All of the above are related to the server side which we usually do not touch. We take the CSS as it is and deploy it. With that being said, I am not sure why you are getting the first two issues. I am able to create a POD in pods.solidcommunity.au without facing those.

srodriguez142857 commented 3 months ago

Please check the following screen recordings:

srodriguez142857 commented 3 months ago

All good, @anushkavidanage. Removing the "back arrow" was clever. The app works well, and no issues were raised on the server side during my testing. I will approve the review.