search

anvilresearch / webcrypto

W3C Web Cryptography API for Node.js
MIT License
82 stars 14 forks source link

RSA parameter selection #67

Closed EternalDeiwos closed 6 years ago

EternalDeiwos commented 6 years ago

The following code (and the same for .verify) should be using this.hash.name as the keys themselves aren't bound to a specific hash.

https://github.com/anvilresearch/webcrypto/blob/master/src/algorithms/RSASSA-PKCS1-v1_5.js#L81-L91

I tried doing a quick fix for this but it breaks all the tests.

thelunararmy commented 6 years ago

Woops, this should be class. Will fix.

thelunararmy commented 6 years ago

Fixed in 97cfbe35fff1880227c3dc3ef13ad922c6f7d5d0 , just waiting for latest merge then I'll PR it.

EternalDeiwos commented 6 years ago

Fixed in #69. Closing.