any1 / wayvnc

A VNC server for wlroots based Wayland compositors
ISC License
1.16k stars 69 forks source link

External listener fd #310

Closed layercak3 closed 5 months ago

layercak3 commented 6 months ago

Tested with a systemd .socket unit.

Closes: https://github.com/any1/wayvnc/issues/227 Requires: https://github.com/any1/neatvnc/pull/111 I have read and understood CONTRIBUTING.md.

layercak3 commented 6 months ago

Looks like the sr.ht CI is being activated on GitHub PRs somehow but I don't see any indication of it checking out to my commit object. If it needs to be on PRs the linker should be failing on mine.

layercak3 commented 6 months ago

Force-pushed new commits with review addressed.

any1 commented 6 months ago

For some reason, the integration test is segfaulting on the github CI, but not srht.

layercak3 commented 6 months ago

I deployed this on my server and external listener fd works, but it seems that I broke normal address listening after the review (I think I remember it working while working on the patch initially), maybe due to the atoi/option parser retval after removing the boolean. I'll have to fix that. As for sr.ht, I stated earlier that I don't see any indication of it checking out to PR heads. Your commit: https://builds.sr.ht/~andri/job/1219324#setup-2245, my commit (not findable from a branch on heads/, but pull/310/head or my fork branch points to it): https://builds.sr.ht/~andri/job/1239409#setup-817

edit: clearly I used the wrong executable to test normal address listening as I forgot to set the default value in the option parser with the option unset, sorry about that

layercak3 commented 6 months ago

I checked on another user's PR and it was doing git checkout (https://builds.sr.ht/~andri/job/1227912), so I was wrong about that, it's only happening to my PRs, probably cause I named the repo "wayvnc-ghfork", maybe a bug in hottub-bridge :)

any1 commented 5 months ago

LGTM. There are conflicts. Can you resolve them?

layercak3 commented 5 months ago

Rebased

any1 commented 5 months ago

Thanks!