anycable / graphql-anycable

A drop-in replacement for GraphQL ActionCable subscriptions. Works with AnyCable.
MIT License
112 stars 18 forks source link

Switch from fakeredis gem to real Redis in tests #31

Closed Envek closed 1 year ago

Envek commented 1 year ago

To facilitate development of pull requests like this: https://github.com/anycable/graphql-anycable/pull/30

Tasks:

arathunku commented 1 year ago

:wave: another point for moving into this direction

WarningHandlers::Ruby::Warning: Redis#srem will always return an Integer in Redis 5.0.0. Use Redis#srem? instead.(called from: /usr/src/app/vendor/bundle/ruby/3.2.0/gems/graphql-anycable-1.1.5/lib/graphql/subscriptions/anycable_subscriptions.rb:196:in `block (2 levels) in delete_subscription')

I'm getting this deprecation warning, see: 4.8.0 release https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#480 and I was going to add PR to switch to srem? but those methods are not even present on fakeredis. Only srem: https://github.com/guilleiguaran/fakeredis/blob/ba7e3b7423884d88b6d30b7ede37ebd489688243/lib/redis/connection/memory.rb#L576