aonez / Keka

The macOS & iOS file archiver
https://www.keka.io
4.92k stars 241 forks source link

Incorrect timeline behavior when archiving - XZ, LZIP, LRZIP #780

Open Oleg-Chashko opened 3 years ago

Oleg-Chashko commented 3 years ago

Incorrect timeline behavior when archiving - XZ, LZIP, LRZIP A folder of about 1200 files and a volume of about 900 megabytes. https://github.com/elrumo/macOS_Big_Sur_icons_replacements/releases/download/v1.0/Icons.zip

Screen Recording:

https://user-images.githubusercontent.com/62497891/106276945-99071180-6238-11eb-87d5-0b2f245b5d26.mov

https://user-images.githubusercontent.com/62497891/106277033-b76d0d00-6238-11eb-8591-deb12f15b89e.mov

https://user-images.githubusercontent.com/62497891/106277081-c3f16580-6238-11eb-8994-16c0e256bc23.mov

If it is not possible to fix, please do as on Screen Shot:

Screen Shot - XZ, LZIP, LRZIP,

To make it clear that the application is working and not freezing.

aonez commented 3 years ago

Thanks Oleg!

I can fix LRZIP.

XZ and LZIP have very unresponsive progress when running multithreaded, tried before to improve it but can't, not even with a MB reading.

You can check it yourself limiting the threads to 1, you'll see the estimation and progress is as expected.

Screenshot 2021-01-29 at 14 29 43

Oleg-Chashko commented 3 years ago

I once again checked the working mode of this Store for XZ and LZIP. For large files, everything that is higher than the Store mode, in my opinion, is somehow not very good: (It's good that I don't use these archive formats. Question: There are no plans to make archiving options in the form of plugins in the future. To reduce the size of the application? And download the necessary plugins via the Internet. For example: RAR plugin - 1.50$, xxx plugin - 2.50$ and etc?

aonez commented 3 years ago

There are no plans to make archiving options in the form of plugins in the future

There're were plans in the past but the introduction of sandboxing broke them. Executing binaries outside the sandboxed bundle is not a thing.

I want to add RAR compression support externally anyway, will see how this goes #123.