apace100 / apoli

MIT License
40 stars 46 forks source link

Fix local/velocity X/Y spaces and add side booleans to add_velocity #15

Closed Alluysl closed 3 years ago

Alluysl commented 3 years ago

Tested all edge cases I could remember of, and more generic cases as well (the times are slightly underestimated): image

The transformVectorToBase method is made public for access in the bi-entity action. It doesn't feel very encapsulated but - in my opinion - it's not worth creating a toGlobal static method that accepts two entities just for this purpose.

Optimized code by the way :P

@eggohito I have a documentation page draft, if and when this is merged, DM me

apace100 commented 3 years ago

Looks fine for me. :) Will merge this into the next feature update (not patch) since it adds serialization data.