search

apace100 / apoli

MIT License
40 stars 46 forks source link

Make the `block_state` block condition type return true if the block state exists in the block #28

Closed eggohito closed 2 years ago

eggohito commented 2 years ago

This PR replaces the break; statement in line 140 to return true; so that it'll return true if the block state exists in the block

apace100 commented 2 years ago

The idea to make the condition return true if the block state contains the specified property but no specific condition for the property's value is specified is good, however your change makes the condition always only check for the presence of the property, and always disregard the specified desired values. I'll reject this PR, as I've implemented this simple change myself in https://github.com/apace100/apoli/commit/f20ac19ec8d113c90000d9858395c804acddffe3.

eggohito commented 2 years ago

Thank you, Apace! I did not realize that return will end the entire method, ignoring the other checks