apache-spark-on-k8s / spark

Apache Spark enhanced with native Kubernetes scheduler back-end: NOTE this repository is being ARCHIVED as all new development for the kubernetes scheduler back-end is now on https://github.com/apache/spark/
https://spark.apache.org/
Apache License 2.0
612 stars 118 forks source link

Enable use of remote dependencies through init-container #582

Closed liyinan926 closed 6 years ago

liyinan926 commented 6 years ago

This is the same PR as https://github.com/apache/spark/pull/19954, but against our fork for triggering integration tests.

@kimoonkim @foxish

foxish commented 6 years ago

The checkstyle failures (in the Full Build test on this PR) seems unrelated to our code - maybe it's broken in upstream/master?

kimoonkim commented 6 years ago

rerun integration test please

kimoonkim commented 6 years ago

rerun integration test please

foxish commented 6 years ago

@kimoonkim, is there a way to tell if it's running the new or the old? Or is it that - if the PR is against master, it will always run the new setup?

kimoonkim commented 6 years ago

We are running the new integration test repo code. I modified other builds like unit tests to exclude the master branch. So going forward, only integration test will trigger from the master branch.

kimoonkim commented 6 years ago

if the PR is against master, it will always run the new setup? Correct.

kimoonkim commented 6 years ago

X default Details

The failed Jenkins build with "default" label is actually from the new integration test Jenkins job. I'll find a way to change the label.

kimoonkim commented 6 years ago

rerun integration test please

kimoonkim commented 6 years ago

rerun integration test please

kimoonkim commented 6 years ago

The latest two Jenkins jobs ran the new integration tests. The "Make Distribution" job built a distro tarball off this PR. The "Integration Tests" job ran tests against the tarball. It failed because of config issue that I just fixed.

foxish commented 6 years ago

@kimoonkim, we should see the make distribution and integration tests pass now?

kimoonkim commented 6 years ago

I am hoping the next runs will pass. Getting there.

kimoonkim commented 6 years ago

Ok. It seems the latest test failure is genuine. @liyinan926 Can you please take a look? Maybe your branch is outdated and need to merge apache/spark#20051

From http://spark-k8s-jenkins.pepperdata.org:8080/job/pr-spark-integration/5/:

Discovery starting. Discovery completed in 145 milliseconds. Run starting. Expected test count is: 2 KubernetesSuite: RUN ABORTED com.spotify.docker.client.exceptions.DockerException: ProgressMessage{id=null, status=null, stream=null, error=lstat dockerfiles/spark-base/entrypoint.sh: no such file or directory, progress=null, progressDetail=null} at com.spotify.docker.client.LoggingBuildHandler.progress(LoggingBuildHandler.java:33) at com.spotify.docker.client.DefaultDockerClient.build(DefaultDockerClient.java:1157) at org.apache.spark.deploy.k8s.integrationtest.docker.SparkDockerImageBuilder.buildImage(SparkDockerImageBuilder.scala:70) at org.apache.spark.deploy.k8s.integrationtest.docker.SparkDockerImageBuilder.buildSparkDockerImages(SparkDockerImageBuilder.scala:64) at org.apache.spark.deploy.k8s.integrationtest.backend.minikube.MinikubeTestBackend.initialize(MinikubeTestBackend.scala:31) at org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.beforeAll(KubernetesSuite.scala:42) at org.scalatest.BeforeAndAfterAll$class.beforeAll(BeforeAndAfterAll.scala:187) at org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.beforeAll(KubernetesSuite.scala:33) at org.scalatest.BeforeAndAfterAll$class.run(BeforeAndAfterAll.scala:253) at org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.org$scalatest$BeforeAndAfter$$super$run(KubernetesSuite.scala:33) ...

foxish commented 6 years ago

Might be best to rebase onto upstream/master

On Fri, Dec 22, 2017 at 3:37 PM, Kimoon Kim notifications@github.com wrote:

Ok. It seems the latest test failure is genuine. @liyinan926 https://github.com/liyinan926 Can you please take a look? Maybe your branch is outdated and need to merge apache/spark#20051 https://github.com/apache/spark/pull/20051

From http://spark-k8s-jenkins.pepperdata.org:8080/job/pr- spark-integration/5/:

Discovery starting. Discovery completed in 145 milliseconds. Run starting. Expected test count is: 2 KubernetesSuite: RUN ABORTED com.spotify.docker.client.exceptions.DockerException: ProgressMessage{id=null, status=null, stream=null, error=lstat dockerfiles/spark-base/entrypoint.sh: no such file or directory, progress=null, progressDetail=null} at com.spotify.docker.client.LoggingBuildHandler.progress( LoggingBuildHandler.java:33) at com.spotify.docker.client.DefaultDockerClient.build( DefaultDockerClient.java:1157) at org.apache.spark.deploy.k8s.integrationtest.docker. SparkDockerImageBuilder.buildImage(SparkDockerImageBuilder.scala:70) at org.apache.spark.deploy.k8s.integrationtest.docker. SparkDockerImageBuilder.buildSparkDockerImages( SparkDockerImageBuilder.scala:64) at org.apache.spark.deploy.k8s.integrationtest.backend. minikube.MinikubeTestBackend.initialize(MinikubeTestBackend.scala:31) at org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.beforeAll( KubernetesSuite.scala:42) at org.scalatest.BeforeAndAfterAll$class.beforeAll(BeforeAndAfterAll. scala:187) at org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.beforeAll( KubernetesSuite.scala:33) at org.scalatest.BeforeAndAfterAll$class.run(BeforeAndAfterAll.scala:253) at org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.org $scalatest$BeforeAndAfter$$super$run(KubernetesSuite.scala:33) ...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache-spark-on-k8s/spark/pull/582#issuecomment-353690880, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3U55v1djkfJyfpnHEIeKpkVo0dJDpSks5tDD1CgaJpZM4RLYI3 .

-- Anirudh Ramanathan

liyinan926 commented 6 years ago

Rebased onto latest upstream/master.

kimoonkim commented 6 years ago

Integration test has passed now!

kimoonkim commented 6 years ago

rerun integration tests please

liyinan926 commented 6 years ago

rerun integration tests please

liyinan926 commented 6 years ago

Closing as the upstream has been merged.