Closed klion26 closed 1 month ago
cc @huyuanfeng2018 @zhoujinsong @majin1102
@majin1102 I've addressed the comments, please take another look when you're free. thanks.
@huyuanfeng2018 @majin1102 thanks for the review and merging!
@klion26
I cannot cherrypick this PR into branch 0.7.x due to some conflicts. Can you help to open another PR to branch 0.7.x to help us fix this issue in branch 0.7.x?
Why are the changes needed?
Close #3218 .
Brief change log
-
How was this patch tested?
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[x] Run test locally before making a pull request
Documentation