search

apache / arrow-rs

Official Rust implementation of Apache Arrow
https://arrow.apache.org/
Apache License 2.0
2.63k stars 807 forks source link

MSRV check on CI #4487

Closed eitsupi closed 1 year ago

eitsupi commented 1 year ago

From #181

Currently, Cargo.toml says that this project support Rust 1.62, but when we actually check the MSRV, it appears to be Rust 1.70.

https://github.com/apache/arrow-rs/blob/08a57e9b3b1f954338ba3b27289935e00bfc6ba4/Cargo.toml#L76

> cargo msrv
Fetching index
Determining the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check

Check for toolchain '1.34.2-x86_64-unknown-linux-gnu' failed with:
┌─────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ error: failed to parse manifest at `/workspaces/arrow-rs/arrow/Cargo.toml`                          │
│                                                                                                     │
│ Caused by:                                                                                          │
│   invalid type: map, expected a sequence for key `package.authors`                                  │
└─────────────────────────────────────────────────────────────────────────────────────────────────────┘

Check for toolchain '1.52.1-x86_64-unknown-linux-gnu' failed with:
┌─────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ error: failed to parse manifest at `/workspaces/arrow-rs/arrow/Cargo.toml`                          │
│                                                                                                     │
│ Caused by:                                                                                          │
│   invalid type: map, expected a sequence for key `package.authors`                                  │
└─────────────────────────────────────────────────────────────────────────────────────────────────────┘

Check for toolchain '1.61.0-x86_64-unknown-linux-gnu' failed with:
┌─────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ error: failed to load manifest for workspace member `/workspaces/arrow-rs/arrow`                    │
│                                                                                                     │
│ Caused by:                                                                                          │
│   failed to parse manifest at `/workspaces/arrow-rs/arrow/Cargo.toml`                               │
│                                                                                                     │
│ Caused by:                                                                                          │
│   invalid type: map, expected a string for key `package.rust-version`                               │
└─────────────────────────────────────────────────────────────────────────────────────────────────────┘

Check for toolchain '1.66.1-x86_64-unknown-linux-gnu' failed with:
┌─────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Updating crates.io index                                                                            │
│  Downloading crates ...                                                                             │
│   Downloaded adler v1.0.2                                                                           │
│   Downloaded half v2.3.1                                                                            │
│   Downloaded flate2 v1.0.26                                                                         │
│   Downloaded lz4 v1.24.0                                                                            │
│   Downloaded heck v0.4.1                                                                            │
│   Downloaded alloc-stdlib v0.2.2                                                                    │
│   Downloaded futures-sink v0.3.28                                                                   │
│   Downloaded const-random-macro v0.1.15                                                             │
│   Downloaded alloc-no-stdlib v2.0.4                                                                 │
│   Downloaded num-rational v0.4.1                                                                    │
│   Downloaded integer-encoding v3.0.4                                                                │
│   Downloaded http-body v0.4.5                                                                       │
│   Downloaded bitflags v1.3.2                                                                        │
│   Downloaded clap_derive v4.3.2                                                                     │
│   Downloaded getrandom v0.2.10                                                                      │
│   Downloaded futures-macro v0.3.28                                                                  │
│   Downloaded fastrand v1.9.0                                                                        │
│   Downloaded either v1.8.1                                                                          │
│   Downloaded miniz_oxide v0.7.1                                                                     │
│   Downloaded memchr v2.5.0                                                                          │
│   Downloaded num-iter v0.1.43                                                                       │
│   Downloaded anyhow v1.0.71                                                                         │
│   Downloaded async-trait v0.1.71                                                                    │
│   Downloaded pin-utils v0.1.0                                                                       │
│   Downloaded futures-channel v0.3.28                                                                │
│   Downloaded sync_wrapper v0.1.2                                                                    │
│   Downloaded csv-core v0.1.10                                                                       │
│   Downloaded base64 v0.21.2                                                                         │
│   Downloaded strum v0.24.1                                                                          │
│   Downloaded crc32fast v1.3.2                                                                       │
│   Downloaded bytes v1.4.0                                                                           │
│   Downloaded mio v0.8.8                                                                             │
│   Downloaded ahash v0.8.3                                                                           │
│   Downloaded fnv v1.0.7                                                                             │
│   Downloaded hashbrown v0.14.0                                                                      │
│   Downloaded hyper v0.14.27                                                                         │
│   Downloaded proc-macro-hack v0.5.20+deprecated                                                     │
│   Downloaded want v0.3.1                                                                            │
│   Downloaded equivalent v1.0.0                                                                      │
│   Downloaded tower-service v0.3.2                                                                   │
│   Downloaded tower-layer v0.3.2                                                                     │
│   Downloaded futures-executor v0.3.28                                                               │
│   Downloaded cfg-if v1.0.0                                                                          │
│   Downloaded const-random v0.1.15                                                                   │
│   Downloaded pin-project-lite v0.2.10                                                               │
│   Downloaded num_cpus v1.16.0                                                                       │
│   Downloaded prost-derive v0.11.9                                                                   │
│   Downloaded rustversion v1.0.13                                                                    │
│   Downloaded lexical-core v0.8.5                                                                    │
│   Downloaded axum-core v0.3.4                                                                       │
│   Downloaded pkg-config v0.3.27                                                                     │
│   Downloaded io-lifetimes v1.0.11                                                                   │
│   Downloaded jobserver v0.1.26                                                                      │
│   Downloaded version_check v0.9.4                                                                   │
│   Downloaded tonic-build v0.9.2                                                                     │
│   Downloaded tokio-macros v2.1.0                                                                    │
│   Downloaded zstd v0.12.3+zstd.1.5.2                                                                │
│   Downloaded unicode-width v0.1.10                                                                  │
│   Downloaded zstd-safe v6.0.5+zstd.1.5.4                                                            │
│   Downloaded tokio-io-timeout v1.2.0                                                                │
│   Downloaded once_cell v1.18.0                                                                      │
│   Downloaded tempfile v3.6.0                                                                        │
│   Downloaded socket2 v0.4.9                                                                         │
│   Downloaded snap v1.1.0                                                                            │
│   Downloaded tiny-keccak v2.0.2                                                                     │
│   Downloaded semver v1.0.17                                                                         │
│   Downloaded tokio-stream v0.1.14                                                                   │
│   Downloaded tracing-attributes v0.1.26                                                             │
│   Downloaded prettyplease v0.1.25                                                                   │
│   Downloaded pin-project v1.1.2                                                                     │
│   Downloaded serde_derive v1.0.167                                                                  │
│   Downloaded matchit v0.7.0                                                                         │
│   Downloaded httparse v1.8.0                                                                        │
│   Downloaded comfy-table v7.0.1                                                                     │
│   Downloaded tracing-core v0.1.31                                                                   │
│   Downloaded num-bigint v0.4.3                                                                      │
│   Downloaded tracing v0.1.37                                                                        │
│   Downloaded brotli-decompressor v2.3.4                                                             │
│   Downloaded hex v0.4.3                                                                             │
│   Downloaded serde v1.0.167                                                                         │
│   Downloaded rand v0.8.5                                                                            │
│   Downloaded static_assertions v1.1.0                                                               │
│   Downloaded tokio-util v0.7.8                                                                      │
│   Downloaded httpdate v1.0.2                                                                        │
│   Downloaded hyper-timeout v0.4.1                                                                   │
│   Downloaded futures-io v0.3.28                                                                     │
│   Downloaded tower v0.4.13                                                                          │
│   Downloaded futures-task v0.3.28                                                                   │
│   Downloaded futures-core v0.3.28                                                                   │
│   Downloaded anstyle v1.0.1                                                                         │
│   Downloaded h2 v0.3.20                                                                             │
│   Downloaded http v0.2.9                                                                            │
│   Downloaded lazy_static v1.4.0                                                                     │
│   Downloaded itoa v1.0.8                                                                            │
│   Downloaded which v4.4.0                                                                           │
│   Downloaded serde_json v1.0.100                                                                    │
│   Downloaded indexmap v1.9.3                                                                        │
│   Downloaded flatbuffers v23.5.26                                                                   │
│   Downloaded hashbrown v0.12.3                                                                      │
│   Downloaded clap_builder v4.3.11                                                                   │
│   Downloaded lexical-parse-integer v0.8.6                                                           │
│   Downloaded byteorder v1.4.3                                                                       │
│   Downloaded futures v0.3.28                                                                        │
│   Downloaded lexical-write-integer v0.8.5                                                           │
│   Downloaded indexmap v2.0.0                                                                        │
│   Downloaded clap v4.3.11                                                                           │
│   Downloaded futures-util v0.3.28                                                                   │
│   Downloaded syn v2.0.23                                                                            │
│   Downloaded lexical-write-float v0.8.5                                                             │
│   Downloaded lexical-util v0.8.5                                                                    │
│   Downloaded percent-encoding v2.3.0                                                                │
│   Downloaded regex v1.9.1                                                                           │
│   Downloaded libc v0.2.147                                                                          │
│   Downloaded crunchy v0.2.2                                                                         │
│   Downloaded num-complex v0.4.3                                                                     │
│   Downloaded multimap v0.8.3                                                                        │
│   Downloaded ordered-float v2.10.0                                                                  │
│   Downloaded ppv-lite86 v0.2.17                                                                     │
│   Downloaded num v0.4.0                                                                             │
│   Downloaded quote v1.0.29                                                                          │
│   Downloaded paste v1.0.13                                                                          │
│   Downloaded slab v0.4.8                                                                            │
│   Downloaded rand_core v0.6.4                                                                       │
│   Downloaded num-integer v0.1.45                                                                    │
│   Downloaded autocfg v1.1.0                                                                         │
│   Downloaded mime v0.3.17                                                                           │
│   Downloaded clap_lex v0.5.0                                                                        │
│   Downloaded rand_chacha v0.3.1                                                                     │
│   Downloaded fixedbitset v0.4.2                                                                     │
│   Downloaded prost-build v0.11.9                                                                    │
│   Downloaded log v0.4.19                                                                            │
│   Downloaded prost v0.11.9                                                                          │
│   Downloaded seq-macro v0.3.4                                                                       │
│   Downloaded libm v0.2.7                                                                            │
│   Downloaded regex-automata v0.3.2                                                                  │
│   Downloaded rustc_version v0.4.0                                                                   │
│   Downloaded pin-project-internal v1.1.2                                                            │
│   Downloaded prost-types v0.11.9                                                                    │
│   Downloaded proc-macro2 v1.0.63                                                                    │
│   Downloaded num-traits v0.2.15                                                                     │
│   Downloaded ryu v1.0.14                                                                            │
│   Downloaded thrift v0.17.0                                                                         │
│   Downloaded zstd-sys v2.0.8+zstd.1.5.5                                                             │
│   Downloaded tokio v1.29.1                                                                          │
│   Downloaded linux-raw-sys v0.3.8                                                                   │
│   Downloaded cc v1.0.79                                                                             │
│   Downloaded iana-time-zone v0.1.57                                                                 │
│   Downloaded strum_macros v0.24.3                                                                   │
│   Downloaded lexical-parse-float v0.8.5                                                             │
│   Downloaded try-lock v0.2.4                                                                        │
│   Downloaded twox-hash v1.6.3                                                                       │
│   Downloaded itertools v0.10.5                                                                      │
│   Downloaded unicode-ident v1.0.10                                                                  │
│   Downloaded aho-corasick v1.0.2                                                                    │
│   Downloaded axum v0.6.18                                                                           │
│   Downloaded tonic v0.9.2                                                                           │
│   Downloaded petgraph v0.6.3                                                                        │
│   Downloaded chrono v0.4.26                                                                         │
│   Downloaded rustix v0.37.23                                                                        │
│   Downloaded syn v1.0.109                                                                           │
│   Downloaded regex-syntax v0.7.3                                                                    │
│   Downloaded lz4-sys v1.9.4                                                                         │
│   Downloaded csv v1.2.2                                                                             │
│   Downloaded brotli v3.3.4                                                                          │
│  Downloading crates ...                                                                             │
│   Downloaded assert_cmd v2.0.11                                                                     │
│  Downloading crates ...                                                                             │
│   Downloaded criterion v0.5.1                                                                       │
│ error: package `half v2.3.1` cannot be built because it requires rustc 1.70 or newer, while the     │
│ currently active rustc version is 1.66.1                                                            │
│ Either upgrade to rustc 1.70 or newer, or use                                                       │
│ cargo update -p half@2.3.1 --precise ver                                                            │
│ where `ver` is the latest version of `half` supporting rustc 1.66.1                                 │
└─────────────────────────────────────────────────────────────────────────────────────────────────────┘

Check for toolchain '1.68.2-x86_64-unknown-linux-gnu' failed with:
┌─────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ error: package `half v2.3.1` cannot be built because it requires rustc 1.70 or newer, while the     │
│ currently active rustc version is 1.68.2                                                            │
│ Either upgrade to rustc 1.70 or newer, or use                                                       │
│ cargo update -p half@2.3.1 --precise ver                                                            │
│ where `ver` is the latest version of `half` supporting rustc 1.68.2                                 │
└─────────────────────────────────────────────────────────────────────────────────────────────────────┘

Check for toolchain '1.69.0-x86_64-unknown-linux-gnu' failed with:
┌─────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ error: package `half v2.3.1` cannot be built because it requires rustc 1.70 or newer, while the     │
│ currently active rustc version is 1.69.0                                                            │
│ Either upgrade to rustc 1.70 or newer, or use                                                       │
│ cargo update -p half@2.3.1 --precise ver                                                            │
│ where `ver` is the latest version of `half` supporting rustc 1.69.0                                 │
└─────────────────────────────────────────────────────────────────────────────────────────────────────┘
Check for toolchain '1.70.0-x86_64-unknown-linux-gnu' succeeded
   Finished The MSRV is: 1.70.0   ████████████████████████████████████████████████████████████ 00:10:27

I would like to be able to check the MSRV on the CI to set the appropriate rust-version on the Cargo.toml.

tustvold commented 1 year ago

label_issue.py automatically added labels {'parquet'} from #4490

tustvold commented 1 year ago

label_issue.py automatically added labels {'arrow'} from #4490

tustvold commented 1 year ago

label_issue.py automatically added labels {'arrow-flight'} from #4490

tustvold commented 1 year ago

label_issue.py automatically added labels {'object-store'} from #4490