search

apache / buildstream

BuildStream, the software integration tool
https://buildstream.build/
Apache License 2.0
85 stars 30 forks source link

source: disable check for URL marking at configure time #1896

Closed abderrahim closed 8 months ago

abderrahim commented 8 months ago

This check is triggered by plugins that have URLs (or URL fragments) as part of their ref, such as cargo. These plugins currently resort to only translating part of the URL and appending the rest later. Dropping the check allows these plugins to call mark_download_url() or translate_url() a second time when tracking.

It also allows plugins to postpone calling them until fetch(), which is the behaviour the check was supposed to prevent. This is still considered wrong, but will no longer trigger an AssertionError.

This MR also removes the _configure() and _get_configuring() methods of Plugin as they are no longer needed.

nanonyme commented 8 months ago

Seems to me the entire marked URL's mechanism should be dropped if this is done. self.__marked_urls doesn't seem to be used anywhere else.

abderrahim commented 8 months ago

superseded by #1899