Closed christophd closed 6 months ago
@davsclaus setting camel.component.kamelet.noErrorHandler=false
would be an option but I think there is a better way when we set the error handler properly for the route, right? could you please advice how we should be adding the Pipe error handler so that it works as expected with Camel 4.4.0 🙏 many thanks
Do you have a sample code for camel jbang that would be easier to look at
I had a look into how Camel JBang handles the error handler on a Pipe and found this example here:
I guess this is the proper way to set the error handler factory on the routeDefinition to a DeadLetterChannelDefinition
for instance. Then is also works with the noErrorHandler
setting in Camel 4.4, right?
Yes camel-yaml-dsl setup the pipe error handler on the route as a pure standard camel fashion. https://github.com/apache/camel/blob/78bd6d70f5af6997d3b4a21085b1bbbde4e2cf70/dsl/camel-yaml-dsl/camel-yaml-dsl/src/main/java/org/apache/camel/dsl/yaml/YamlRoutesBuilderLoader.java#L828
Relates to https://github.com/apache/camel/pull/13489
What happened?
Since Camel 4.4.0 the Kamelets error handler has been removed and noErrorHandler is used by default (see https://github.com/apache/camel/commit/5e2a89635bde02df40925f65b430882b35a60bd0 and https://issues.apache.org/jira/browse/CAMEL-19411)
This also has impact on the Pipe error handler (see failing tests in nightly runtime checks https://github.com/apache/camel-k/actions/workflows/nightly-latest-runtime.yml)
There is a new option on the camel-kamelets component that resets to the former error handler behavior (
camel.component.kamelet.noErrorHandler=false
). We may set this when the Pipe uses an error handler to get it back working.Steps to reproduce
Relevant log output
Camel K version
2.3.0-SNAPSHOT