apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
170 stars 89 forks source link

Feature/747 fix codecov #748

Closed pnoltes closed 5 months ago

pnoltes commented 6 months ago

Hotfix pull request that fixes the codecov upload issue, by using a GitHub codecov token secret. This is a hotfix and as such will follow the merge then review procedure.

Closes #747

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.20%. Comparing base (cb38185) to head (8b30826). Report is 32 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #748 +/- ## ========================================== + Coverage 90.17% 90.20% +0.03% ========================================== Files 223 225 +2 Lines 26545 26393 -152 ========================================== - Hits 23936 23807 -129 + Misses 2609 2586 -23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pnoltes commented 6 months ago

Note the coverage also dropped to about 60%. I think is because the test sources are also includes and make coverage excludes the test files for coverage. I will look into this before merging this PR.

pnoltes commented 5 months ago

I am still testing some small changes to see if I can get a cleaner log. After that, I will create a new pull request with a single commit to fix codecov. In my opinion, the small trial and error commits in this PR will unnecessarily clutter the commit log.