Closed pnoltes closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.20%. Comparing base (
cb38185
) to head (8b30826
). Report is 32 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note the coverage also dropped to about 60%. I think is because the test sources are also includes and make coverage
excludes the test files for coverage. I will look into this before merging this PR.
I am still testing some small changes to see if I can get a cleaner log. After that, I will create a new pull request with a single commit to fix codecov. In my opinion, the small trial and error commits in this PR will unnecessarily clutter the commit log.
Hotfix pull request that fixes the codecov upload issue, by using a GitHub codecov token secret. This is a hotfix and as such will follow the merge then review procedure.
Closes #747